-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #5197: Adds telemetry for media notification #5520
Conversation
ab3b9da
to
ae402bd
Compare
Do not land this until we decide which A-C version we're pinning for 2.1 |
Even though it may not be in the last 14.0.0-SNAPSHOT ... I'm pretty sure it made 14.0.0 release! |
ae402bd
to
5ab9516
Compare
Codecov Report
@@ Coverage Diff @@
## master #5520 +/- ##
============================================
- Coverage 14.04% 14.03% -0.02%
Complexity 311 311
============================================
Files 255 255
Lines 10414 10426 +12
Branches 1507 1511 +4
============================================
Hits 1463 1463
- Misses 8840 8852 +12
Partials 111 111
Continue to review full report at Codecov.
|
5ab9516
to
65147a6
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
65147a6
to
3b623ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, in metrics.yaml and metrics.md
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, Fenix data controls
- If the request is for permanent data collection, is there someone who will monitor the data over time?
Fenix PM Vesta will monitor, and this has an expiry
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2 for interaction with the media controls
- Is the data collection request for default-on or default-off?
Default on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
no
- Is the data collection covered by the existing Firefox privacy notice?
Yes
- Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
Has expiry, 3/2020
- Does the data collection use a third-party collection tool? If yes, escalate to legal.
No
Pull Request checklist
After merge
To download an APK when reviewing a PR: