Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5281 - Use TrackerLog for reporting ETP categories #5556

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Sep 25, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@ekager ekager requested a review from Amejia481 September 25, 2019 06:00
@Amejia481
Copy link
Contributor

In general it looks good :)

@ekager ekager marked this pull request as ready for review September 25, 2019 15:42
@ekager ekager requested review from a team as code owners September 25, 2019 15:42
@ekager ekager requested a review from Amejia481 September 25, 2019 15:43
@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #5556 into master will decrease coverage by 0.05%.
The diff coverage is 22.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5556      +/-   ##
============================================
- Coverage     14.04%   13.99%   -0.06%     
+ Complexity      311      308       -3     
============================================
  Files           255      255              
  Lines         10415    10432      +17     
  Branches       1507     1513       +6     
============================================
- Hits           1463     1460       -3     
- Misses         8841     8858      +17     
- Partials        111      114       +3
Impacted Files Coverage Δ Complexity Δ
.../trackingprotection/TrackingProtectionPanelView.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...rotection/TrackingProtectionPanelDialogFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...enix/trackingprotection/TrackingProtectionStore.kt 94.91% <100%> (+0.97%) 1 <0> (ø) ⬇️
...mozilla/fenix/trackingprotection/TrackerBuckets.kt 39.13% <33.33%> (-18.57%) 3 <1> (-3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2829235...b5b9c65. Read the comment docs.

@ekager
Copy link
Contributor Author

ekager commented Sep 25, 2019

Cleaned it up and added back some tests :)

Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Amejia481 Amejia481 merged commit b0b60aa into mozilla-mobile:master Sep 25, 2019
@ekager ekager deleted the new-categories branch November 4, 2019 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants