Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5737: Adds telemetry for open links in a private tab #5975

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Oct 11, 2019


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz force-pushed the launch-links-telem branch from 386a86f to 5f245f1 Compare October 11, 2019 22:20
@sblatz
Copy link
Contributor Author

sblatz commented Oct 11, 2019

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
    -How many users enable the Launch in private tab toggle
    -How often users launch a link in private tab

  2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

  • We want to know if users are using the "open links in private mode" setting so we can prioritize work on this feature in the future.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A (These are baseline metrics)
  1. Can current instrumentation answer these questions?
  • Currently there are no events to track this preference, though we do track other suggestion toggles, so we'd like data on this one as well.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?

Until 03/01/2020

  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@sblatz sblatz requested a review from boek October 11, 2019 22:22
@sblatz sblatz added the needs:data-review PR is awaiting a data review label Oct 11, 2019
@codecov-io
Copy link

codecov-io commented Oct 11, 2019

Codecov Report

Merging #5975 into master will increase coverage by <.01%.
The diff coverage is 17.64%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5975      +/-   ##
============================================
+ Coverage     14.73%   14.73%   +<.01%     
  Complexity      319      319              
============================================
  Files           262      262              
  Lines         10732    10748      +16     
  Branches       1560     1561       +1     
============================================
+ Hits           1581     1584       +3     
- Misses         9025     9038      +13     
  Partials        126      126
Impacted Files Coverage Δ Complexity Δ
...la/fenix/components/metrics/GleanMetricsService.kt 7.47% <0%> (-0.09%) 3 <0> (ø)
...n/java/org/mozilla/fenix/IntentReceiverActivity.kt 39.53% <20%> (-5.92%) 4 <0> (ø)
...va/org/mozilla/fenix/components/metrics/Metrics.kt 25.58% <25%> (+0.1%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c98f9...01a90e6. Read the comment docs.

@sblatz
Copy link
Contributor Author

sblatz commented Oct 21, 2019

Bumping @boek on this :)

@sblatz
Copy link
Contributor Author

sblatz commented Oct 23, 2019

Bumping @boek

@@ -138,7 +138,8 @@ sealed class Event {
context.getString(R.string.pref_key_search_bookmarks),
context.getString(R.string.pref_key_search_browsing_history),
context.getString(R.string.pref_key_show_clipboard_suggestions),
context.getString(R.string.pref_key_show_search_shortcuts)
context.getString(R.string.pref_key_show_search_shortcuts),
R.string.pref_key_open_links_in_a_private_tab
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to wrap this in context.getString?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup 🙃

Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Review Form (to be filled by Data Stewards)

Instructions: Data Stewards will review a request for data collection and endorse responses to each question. If the request does not provide answers to questions, reviewers give an r- and point to the questions that can’t be answered.

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, updated metrics.yaml, metrics.md

  1. Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, fenix data controls

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Expiry 3/2020

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 2

  1. Is the data collection request for default-on or default-off?

Default on

  1. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No, UI telemetry

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes, usage data

  1. Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

Has expiry

  1. Does the data collection use a third-party collection tool? If yes, escalate to legal.

No

@boek
Copy link
Contributor

boek commented Oct 23, 2019

I had the review filled out, never hit submit :|

@sblatz sblatz force-pushed the launch-links-telem branch from 5f245f1 to 0c910ae Compare October 23, 2019 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:data-review PR is awaiting a data review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants