-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #5737: Adds telemetry for open links in a private tab #5975
Conversation
386a86f
to
5f245f1
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
Until 03/01/2020
|
Codecov Report
@@ Coverage Diff @@
## master #5975 +/- ##
============================================
+ Coverage 14.73% 14.73% +<.01%
Complexity 319 319
============================================
Files 262 262
Lines 10732 10748 +16
Branches 1560 1561 +1
============================================
+ Hits 1581 1584 +3
- Misses 9025 9038 +13
Partials 126 126
Continue to review full report at Codecov.
|
Bumping @boek on this :) |
Bumping @boek |
@@ -138,7 +138,8 @@ sealed class Event { | |||
context.getString(R.string.pref_key_search_bookmarks), | |||
context.getString(R.string.pref_key_search_browsing_history), | |||
context.getString(R.string.pref_key_show_clipboard_suggestions), | |||
context.getString(R.string.pref_key_show_search_shortcuts) | |||
context.getString(R.string.pref_key_show_search_shortcuts), | |||
R.string.pref_key_open_links_in_a_private_tab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to wrap this in context.getString
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
Instructions: Data Stewards will review a request for data collection and endorse responses to each question. If the request does not provide answers to questions, reviewers give an r- and point to the questions that can’t be answered.
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, updated metrics.yaml, metrics.md
- Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.
Yes, fenix data controls
- If the request is for permanent data collection, is there someone who will monitor the data over time?
Expiry 3/2020
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2
- Is the data collection request for default-on or default-off?
Default on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No, UI telemetry
- Is the data collection covered by the existing Firefox privacy notice?
Yes, usage data
- Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
Has expiry
- Does the data collection use a third-party collection tool? If yes, escalate to legal.
No
I had the review filled out, never hit submit :| |
5f245f1
to
0c910ae
Compare
0c910ae
to
01a90e6
Compare
Pull Request checklist
After merge
To download an APK when reviewing a PR: