-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #5583 - Adds telemetry for download notification #6554
Conversation
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
e034044
to
5e80d0d
Compare
Codecov Report
@@ Coverage Diff @@
## master #6554 +/- ##
============================================
- Coverage 16.77% 16.73% -0.05%
Complexity 349 349
============================================
Files 271 271
Lines 10650 10681 +31
Branches 1483 1492 +9
============================================
Hits 1787 1787
- Misses 8716 8747 +31
Partials 147 147
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
-
Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, metrics.yaml and metrics.md -
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, under data controls -
If the request is for permanent data collection, is there someone who will monitor the data over time?
Has expiry -
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2 -
Is the data collection request for default-on or default-off?
Default on -
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No -
Is the data collection covered by the existing Firefox privacy notice?
Yes -
Does there need to be a check-in in the future to determine whether to renew the data?
Will check-in at expiry -
Does the data collection use a third-party collection tool?
No
This fixes #5583. We pick up the
Fact
s emitted from theDownloads
copmonent that are documented in https://github.com/mozilla-mobile/android-components/tree/master/components/feature/downloads#facts.It also adds 2 telemetry probes into DownloadNotificationBottomSheetDialog to track in-app notification usage:
Pull Request checklist
After merge
To download an APK when reviewing a PR: