For #6396 - Added metrics for history/bookmarks account sync

[BranescuMihai]

---

Pull Request checklist

• Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
• Tests: This PR just adds metrics
• Screenshots: This PR doesn't include screenshots, only metrics
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

• Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[BranescuMihai]

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?

• How many users turn off sync for either bookmarks or history?
• How many users do not interact with Sync settings?

2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

• We want to know if users choose to enable/disable sync for history/bookmarks separately, so we can plan future sync related features accordingly.

3. What alternative methods did you consider to answer these questions? Why were they not sufficient?

• N/A (These are baseline metrics)

4. Can current instrumentation answer these questions?

• No, history/bookmarks sync toggle is a recently added feature and we cannot currently determine if they disabled each individually.

5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.

• All data is Category 2.

6. How long will this data be collected?

Until 03/01/2020

7. What populations will you measure?

• All release, beta, and nightly users with telemetry enabled.

8. Please provide a general description of how you will analyze this data.

• Glean / Amplitude

9. Where do you intend to share the results of your analysis?

• Only on Glean, Amplitude and with mobile teams.

[boek]

Data Review Form (to be filled by Data Stewards)

Instructions: Data Stewards will review a request for data collection and endorse responses to each question. If the request does not provide answers to questions, reviewers give an r- and point to the questions that can’t be answered.

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
   Yes, metrics.yaml and metrics.md

2. Is there a control mechanism that allows the user to turn the data collection on and off? Yes, under data controls

3. If the request is for permanent data collection, is there someone who will monitor the data over time? Has expiry

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
   Type 2

5. Is the data collection request for default-on or default-off?
   Default on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
   No

7. Is the data collection covered by the existing Firefox privacy notice?
   Yes

8. Does there need to be a check-in in the future to determine whether to renew the data? Will check in at expiry

9. Does the data collection use a third-party collection tool? No

[codecov-io]

Codecov Report

Merging #6601 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #6601      +/-   ##
============================================
- Coverage      17.3%   17.28%   -0.02%     
  Complexity      391      391              
============================================
  Files           281      281              
  Lines         11225    11235      +10     
  Branches       1546     1546              
============================================
  Hits           1942     1942              
- Misses         9128     9138      +10     
  Partials        155      155

Impacted Files	Coverage Δ	Complexity Δ
.../fenix/settings/account/AccountSettingsFragment.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...va/org/mozilla/fenix/components/metrics/Metrics.kt	20.24% <0%> (-0.17%)	0 <0> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a21540...be94e69. Read the comment docs.