Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #6436: Adds snackbar for failed download #6648

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Nov 16, 2019


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Copy link
Contributor

@severinrudie severinrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

onCannotOpenFile = {
FenixSnackbar.make(view, Snackbar.LENGTH_SHORT)
.setText(context.getString(R.string.mozac_feature_downloads_could_not_open_file))
.setAnchorView(browserToolbarView.view)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No action needed here, but I'm concerned about BaseBrowserFragment#initializeUI. It's already 255 lines! We could pull these initializations out into helper methods, but it would mostly be a cosmetic change.

I don't know what to do here yet, but I think this is an important smell that we should be thinking about.

@sblatz sblatz force-pushed the fix-download-completed-open branch from 58a3c0c to 28af3fa Compare November 22, 2019 18:52
@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

Merging #6648 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6648      +/-   ##
============================================
- Coverage     17.33%   17.32%   -0.02%     
  Complexity      390      390              
============================================
  Files           280      280              
  Lines         11206    11213       +7     
  Branches       1573     1574       +1     
============================================
  Hits           1943     1943              
- Misses         9109     9116       +7     
  Partials        154      154
Impacted Files Coverage Δ Complexity Δ
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...downloads/DownloadNotificationBottomSheetDialog.kt 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc1ea9...0bd7410. Read the comment docs.

@sblatz sblatz force-pushed the fix-download-completed-open branch from 28af3fa to 0bd7410 Compare November 22, 2019 19:44
@sblatz sblatz merged commit bcf80d0 into mozilla-mobile:master Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants