-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #6436: Adds snackbar for failed download #6648
For #6436: Adds snackbar for failed download #6648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
app/src/main/java/org/mozilla/fenix/downloads/DownloadNotificationBottomSheetDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/downloads/DownloadNotificationBottomSheetDialog.kt
Outdated
Show resolved
Hide resolved
onCannotOpenFile = { | ||
FenixSnackbar.make(view, Snackbar.LENGTH_SHORT) | ||
.setText(context.getString(R.string.mozac_feature_downloads_could_not_open_file)) | ||
.setAnchorView(browserToolbarView.view) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No action needed here, but I'm concerned about BaseBrowserFragment#initializeUI
. It's already 255 lines! We could pull these initializations out into helper methods, but it would mostly be a cosmetic change.
I don't know what to do here yet, but I think this is an important smell that we should be thinking about.
app/src/main/java/org/mozilla/fenix/downloads/DownloadNotificationBottomSheetDialog.kt
Show resolved
Hide resolved
58a3c0c
to
28af3fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #6648 +/- ##
============================================
- Coverage 17.33% 17.32% -0.02%
Complexity 390 390
============================================
Files 280 280
Lines 11206 11213 +7
Branches 1573 1574 +1
============================================
Hits 1943 1943
- Misses 9109 9116 +7
Partials 154 154
Continue to review full report at Codecov.
|
28af3fa
to
0bd7410
Compare
Pull Request checklist
After merge
To download an APK when reviewing a PR: