-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #6556: Adds Telemetry counts for Search Access Points #7310
For #6556: Adds Telemetry counts for Search Access Points #7310
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7310 +/- ##
============================================
- Coverage 19.36% 19.13% -0.24%
+ Complexity 458 441 -17
============================================
Files 298 292 -6
Lines 11503 11311 -192
Branches 1563 1544 -19
============================================
- Hits 2228 2164 -64
+ Misses 9097 8976 -121
+ Partials 178 171 -7
Continue to review full report at Codecov.
|
bc15f2f
to
791c566
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
-
Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, metrics.yaml and metrics.md -
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, under data controls -
If the request is for permanent data collection, is there someone who will monitor the data over time?
Has expiry -
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2 -
Is the data collection request for default-on or default-off?
Default on -
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No -
Is the data collection covered by the existing Firefox privacy notice?
Yes -
Does there need to be a check-in in the future to determine whether to renew the data?
Will check-in at expiry -
Does the data collection use a third-party collection tool?
No
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops had some comments left over from when i didn't finish the review
app/src/main/java/org/mozilla/fenix/components/metrics/MetricsUtils.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/components/metrics/MetricsUtils.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt
Outdated
Show resolved
Hide resolved
Added two new sources to be counted ('widget' and 'shortcut') besides 'action' and 'suggestion'. Also modified/fixed some tests.
791c566
to
32439e3
Compare
7697: For mozilla-mobile/fenix#7310 - Adds bypassCache parameter to reload. r=csadilek a=boek For mozilla-mobile/fenix#7310 - Adds bypassCache parameter to reload. Co-authored-by: Jeff Boek <jeff@jeffboek.com>
Added two new sources to be counted ('widget' and 'shortcut') besides 'action' and
'suggestion'. Also modified/fixed some tests.
Pull Request checklist
After merge
To download an APK when reviewing a PR: