Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #6556: Adds Telemetry counts for Search Access Points #7310

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

ValentinTimisica
Copy link
Contributor

Added two new sources to be counted ('widget' and 'shortcut') besides 'action' and
'suggestion'. Also modified/fixed some tests.

Pull Request checklist

  • Tests: This PR includes thorough tests.
  • Screenshots: This PR does not include screenshots or GIFs of the changes made.
  • Accessibility: The code in this PR follows accessibility best practices.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@ValentinTimisica ValentinTimisica added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Dec 20, 2019
@codecov-io
Copy link

codecov-io commented Dec 20, 2019

Codecov Report

Merging #7310 into master will decrease coverage by 0.23%.
The diff coverage is 56.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7310      +/-   ##
============================================
- Coverage     19.36%   19.13%   -0.24%     
+ Complexity      458      441      -17     
============================================
  Files           298      292       -6     
  Lines         11503    11311     -192     
  Branches       1563     1544      -19     
============================================
- Hits           2228     2164      -64     
+ Misses         9097     8976     -121     
+ Partials        178      171       -7
Impacted Files Coverage Δ Complexity Δ
...in/java/org/mozilla/fenix/search/SearchFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/org/mozilla/fenix/search/SearchFragmentStore.kt 57.89% <0%> (-1.57%) 1 <0> (ø)
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 8.82% <0%> (-2.9%) 8 <0> (-2)
...va/org/mozilla/fenix/components/metrics/Metrics.kt 24.3% <100%> (+2.93%) 0 <0> (ø) ⬇️
...la/fenix/home/intent/StartSearchIntentProcessor.kt 59.09% <46.66%> (-12.34%) 5 <0> (ø)
.../java/org/mozilla/fenix/search/SearchController.kt 78.94% <60%> (-1.7%) 0 <0> (ø)
...g/mozilla/fenix/components/metrics/MetricsUtils.kt 66.66% <66.66%> (ø) 5 <5> (?)
...nix/home/intent/SpeechProcessingIntentProcessor.kt 93.33% <80%> (-6.67%) 5 <0> (ø)
...zilla/fenix/session/NotificationSessionObserver.kt 0% <0%> (-42.86%) 0% <0%> (-3%)
...fenix/components/metrics/LeanplumMetricsService.kt 7.54% <0%> (-18.43%) 1% <0%> (-1%)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93437c...32439e3. Read the comment docs.

@ValentinTimisica
Copy link
Contributor Author

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • What search access points are most used by the users?
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • Provide information essential to advancing the business objective of increasing search volume in Firefox’s search access points (SAPs).
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A (These are baseline metrics).
  1. Can current instrumentation answer these questions?
  • No.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?
  • Until re-evaluation 03-01-2020.
  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude.
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@ValentinTimisica ValentinTimisica changed the title For #6556: Adds Telemetry counts for Search Access Points [WIP] For #6556: Adds Telemetry counts for Search Access Points Dec 23, 2019
@ValentinTimisica ValentinTimisica removed the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Dec 23, 2019
@ekager ekager added the needs:data-review PR is awaiting a data review label Jan 9, 2020
Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Review Form (to be filled by Data Stewards)

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes, metrics.yaml and metrics.md

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, under data controls

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?
    Has expiry

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    Type 2

  5. Is the data collection request for default-on or default-off?
    Default on

  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
    No

  7. Is the data collection covered by the existing Firefox privacy notice?
    Yes

  8. Does there need to be a check-in in the future to determine whether to renew the data?
    Will check-in at expiry

  9. Does the data collection use a third-party collection tool?
    No

@boek boek added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:data-review PR is awaiting a data review labels Jan 15, 2020
Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops had some comments left over from when i didn't finish the review

Added two new sources to be counted ('widget' and 'shortcut') besides 'action' and
'suggestion'. Also modified/fixed some tests.
@ValentinTimisica ValentinTimisica merged commit 981d19d into mozilla-mobile:master Jan 16, 2020
boek added a commit to boek/android-components that referenced this pull request Jul 13, 2020
boek added a commit to boek/android-components that referenced this pull request Jul 13, 2020
bors bot pushed a commit to mozilla-mobile/android-components that referenced this pull request Jul 14, 2020
7697: For mozilla-mobile/fenix#7310 - Adds bypassCache parameter to reload. r=csadilek a=boek

For mozilla-mobile/fenix#7310 - Adds bypassCache parameter to reload. 


Co-authored-by: Jeff Boek <jeff@jeffboek.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants