Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #255: Removes autoplay media feature flag #8198

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Feb 7, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz requested a review from ekager February 7, 2020 11:48
@codecov-io
Copy link

codecov-io commented Feb 7, 2020

Codecov Report

Merging #8198 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8198      +/-   ##
============================================
- Coverage     18.76%   18.72%   -0.05%     
+ Complexity      454      452       -2     
============================================
  Files           315      315              
  Lines         12307    12300       -7     
  Branches       1617     1616       -1     
============================================
- Hits           2310     2303       -7     
- Misses         9797     9798       +1     
+ Partials        200      199       -1
Impacted Files Coverage Δ Complexity Δ
...pp/src/main/java/org/mozilla/fenix/FeatureFlags.kt 0% <ø> (-100%) 0 <0> (-2)
...ettings/sitepermissions/SitePermissionsFragment.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 71.86% <100%> (ø) 28 <0> (ø) ⬇️
app/src/main/java/org/mozilla/fenix/Config.kt 30.55% <0%> (-2.78%) 2% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29522d2...c354ee2. Read the comment docs.

@gabrielluong gabrielluong merged commit 0a6881d into mozilla-mobile:master Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants