-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #6577 - total_uri_count
Glean telemetry
#8314
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8314 +/- ##
===========================================
- Coverage 18.53% 18.5% -0.04%
Complexity 452 452
===========================================
Files 317 317
Lines 12485 12479 -6
Branches 1641 1641
===========================================
- Hits 2314 2309 -5
+ Misses 9972 9971 -1
Partials 199 199
Continue to review full report at Codecov.
|
Please fill out a data review request form and add it as a comment here, I'll review it right away 😁! |
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me from a Glean usage point of view. Please address the nits below as well :)
Oh, let's also wait for @sblatz to review this, since I don't own this repo :-P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
-
Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, metrics.yaml and metrics.md -
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, under data controls -
If the request is for permanent data collection, is there someone who will monitor the data over time?
Has expiry -
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2 -
Is the data collection request for default-on or default-off?
Default on -
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No -
Is the data collection covered by the existing Firefox privacy notice?
Yes -
Does there need to be a check-in in the future to determine whether to renew the data?
Has expiry -
Does the data collection use a third-party collection tool?
no
Use
total_uri_count
as a Glean CounterMetricType tracked in both thebaseline
andmetrics
ping.This would also complement the changes for #4456.
Pull Request checklist
After merge
To download an APK when reviewing a PR: