-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
app/metrics.yaml
Outdated
bugs: | ||
- https://github.com/mozilla-mobile/fenix/issues/9834 | ||
data_reviews: | ||
- https://github.com/mozilla-mobile/fenix/issues/9835 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be a link to a data review response (once you get it).
Codecov Report
@@ Coverage Diff @@
## master #9835 +/- ##
============================================
+ Coverage 19.07% 19.14% +0.07%
+ Complexity 533 521 -12
============================================
Files 343 337 -6
Lines 13946 13716 -230
Branches 1869 1840 -29
============================================
- Hits 2660 2626 -34
+ Misses 11046 10850 -196
Partials 240 240 Continue to review full report at Codecov.
|
5fd24d2
to
df3e6f9
Compare
cc @boek @liuche as mobile data stewards. Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
How users are interacting with FxA in Fenix - creating an account, login. Specifically when the users choose to use the email login over other means.
We need to provide our users with a seamless, robust and easy-to-use FxA experience, and these metrics help us understand if our implementation is working as expected, and which kinds of authentication flows users are following.
An alternative could be to rely FxA metrics, but these do not allow us to complete a coherent picture of what's going on in a local authentication funnel, and some of the key local events (account recovery, auto-login) are not visible outside of the local client.
No. We tried to measure this and found this regression.
All data is Category 2.
This is scoped to a time-limited experiment/project until date "2020-09-01", at which point it'll be reviewed for renewal.
All release, beta, and nightly users with telemetry enabled.
This is part of events telemetry, so can be disabled via Data Collection settings.
Dashboards in redash and amplitude from glean data.
Internally with the mobile teams, and on redash/aplitude.
N/A |
df3e6f9
to
6f893e3
Compare
app/metrics.yaml
Outdated
bugs: | ||
- https://github.com/mozilla-mobile/fenix/issues/9834 | ||
data_reviews: | ||
- https://github.com/mozilla-mobile/fenix/pull/9835#issuecomment-612951889 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a link to the data steward's response, not the review form itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, but sometimes we also just link to the PR with both of the forms 🤷♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just following the best example I had https://github.com/mozilla-mobile/fenix/pull/4931/files#diff-dcd3c2fb5158fcd99c56aa5b26b6de5dR826
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every time I've had a review from from glean folks, they've been pretty insistent on it :)
6f893e3
to
6a06ffb
Compare
Rebased and resolved the metrics doc comment 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
Instructions: Data Stewards will review a request for data collection and endorse responses to each question.
-
Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, with metrics.yaml and metrics.md -
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, in the Fenix settings -
If the request is for permanent data collection, is there someone who will monitor the data over time?
Has expiry, Fenix team will monitor -
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
All data is category 2. -
Is the data collection request for default-on or default-off?
Default on -
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No -
Is the data collection covered by the existing Firefox privacy notice?
yes -
Does there need to be a check-in in the future to determine whether to renew the data?
Has expiry. Fenix team will monitor -
Does the data collection use a third-party collection tool?
No
6a06ffb
to
acb1b54
Compare
Rebased and updated with the review link. Thank you Jeff! |
Fixes #9834
Fixes a metrics regression introduced in https://github.com/mozilla-mobile/fenix/pull/4931/files#diff-c0328a8e65981c7ed9bdbb1d366c2849R225 with the removal of the event.
Pull Request checklist
explanation: telemetry changes, didn't see any tests for this particular code path.
explanation: no visual changes
After merge
To download an APK when reviewing a PR: