Bugfix FXIOS-10509 ⁃ [Experiment] The Menu Redesign CFR should be displayed for new users that have seen the old menu #23090
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…played for new users that have seen the old menu
Client.app: Coverage: 30.15
Generated by 🚫 Danger Swift against 3d6bb7e |
| if InstallType.get() == .fresh { | ||
| if let photonMainMenuShown = profile.prefs.boolForKey(PrefsKeys.PhotonMainMenuShown), | ||
| photonMainMenuShown { | ||
| return viewProvider.shouldPresentContextualHint() ? true : false |
There was a problem hiding this comment.
I'm confused here
return viewProvider.shouldPresentContextualHint() ? true : falseif true return true and if false return false? Why are we doing this?
There was a problem hiding this comment.
That is true... changed it! Thank you!
adudenamedruby
approved these changes
Nov 13, 2024
adudenamedruby
deleted the
afarcasanu/fxios_10509_23042_menu_redesign_cfr_should_be_displayed_for_new_users_that_have_seen_the_old_menu
branch
|
@Mergifyio backport release/v133 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
…users that have seen the old menu (#23090) * FXIOS-10509 #23042 ⁃ [Experiment] The Menu Redesign CFR should be displayed for new users that have seen the old menu * Refactored two lines of code (cherry picked from commit a8321d3)
6 tasks
dicarobinho
added a commit
that referenced
this pull request
Nov 14, 2024
…played for new users that have seen the old menu (backport #23090) (#23105) Bugfix FXIOS-10509 [Menu] [CFR] Menu CFR should be displayed for new users that have seen the old menu (#23090) * FXIOS-10509 #23042 ⁃ [Experiment] The Menu Redesign CFR should be displayed for new users that have seen the old menu * Refactored two lines of code (cherry picked from commit a8321d3) Co-authored-by: dicarobinho <61138287+dicarobinho@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Display the Menu CFR for fresh installs but only fot the users that have seen before the old menu
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)