Add FXIOS-10544-[Native Error Page] updated string for generic error #23103
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyndichin
reviewed
Nov 13, 2024
| tableName: "NativeErrorPage", | ||
| value: "An SSL error has occurred and a secure connection to the server cannot be made.", | ||
| value: "The owner of %@ hasn’t set it up properly and a secure connection can’t be created.", |
There was a problem hiding this comment.
since we are changing the string, lets move the old one to the old struct. See process here:
https://github.com/mozilla-mobile/firefox-ios/wiki/How-to-add-and-modify-Strings#how-to-modify-a-string
Also, since we have %@, lets add a comment to clarify what that value represents
There was a problem hiding this comment.
Thank you for pointing this out!
"On error page, this is the description for generic error. The placeholder will be replaced by the site url".
Does this work?
Generated by 🚫 Danger Swift against cd051fc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Updated generic error screen strings.
For reference: https://www.figma.com/design/yawrXicozZQ2zvLYsjdQBb/Error-Pages?node-id=5211-3601&t=ffCR7mFR9qjjddHc-4
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)