Refactor FXIOS-10205 [Swiftlint] Removed two unused files that contained implicitly_unwrapped_optional violations #23890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilippoZazzeroni
approved these changes
Dec 19, 2024
Generated by 🚫 Danger Swift against 3c09f23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Continuing resolving
implicitly_unwrapped_optionalviolations in order to enable the rule for further developments.I found two unused files under
Client/Frontendthat contained violations, they aren't referenced in the XCode project file and a global search for the classes they contained returned nothing. Let me know if that's okay for to delete them, otherwise I will simply restore the files resolve the violations themselves 👍📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)