Add FXIOS-10009 [Bookmarks Evolution] Update Bookmarks Panel View Edit Mode Part 2

[DanielDervishi]

📜 Tickets

Jira ticket
Github issue

💡 Description

• Added the ability to undo bookmark deletion for bookmarks/folders
• Updated edit affordances
• Added drag and drop into folders for bookmarks/folders

📝 Checklist

You have to check all boxes before merging

• Filled in the above information (tickets numbers and description of your work)
• Updated the PR name to follow our PR naming guidelines
• Wrote unit tests and/or ensured the tests suite is passing
• When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• If needed, I updated documentation / comments for complex code and public methods
• If needed, added a backport comment (example @Mergifyio backport release/v120)

[lmarceau]

Bunch of nits related to self. usage (which is part of our Swift style guide), and indentation.

Some other comments are bit more of importance, let me know if I can provide further information on any of those!

[lmarceau]

LGTM!

[MattLichtenstein]

A couple of observations from a implementation / usability perspective:

• Deleting the recent bookmarks folder and then undoing the deletion doesn't reset the folder as the recent bookmarks folder location again. Do you think it should?

• At some font sizes, there is not much, if any spacing between the bookmark/folder title and the "edit" action button in the undo toast when the title is long

• When font size is large, the "Undo" button in the toast has a weird border that I don't see on other toasts with action buttons

[mobiletest-ci-bot]

	Warnings
⚠️	Deferred class seems to be used in file firefox-ios/Client/Frontend/Library/Bookmarks/Utitlity/BookmarksSaver.swift at line 97. Please consider replacing with completion handler instead.

	Messages
📖	Project coverage: 33.67%
📖	Edited 8 files
📖	Created 0 files

Client.app: Coverage: 32.56

File	Coverage
HistoryPanel.swift	34.76%	⚠️
LocalDesktopFolder.swift	37.5%	⚠️
BookmarksViewController.swift	8.88%	⚠️
OneLineTableViewCell.swift	0.0%	⚠️
BookmarksFolderCell.swift	0.0%	⚠️
BookmarksSaver.swift	97.99%	✅

Generated by 🚫 Danger Swift against d16b282

[DanielDervishi]

• At some font sizes, there is not much, if any spacing between the bookmark/folder title and the "edit" action button in the undo toast when the title is long

A couple of observations from a implementation / usability perspective:

* Deleting the recent bookmarks folder and then undoing the deletion doesn't reset the folder as the recent bookmarks folder location again. Do you think it should?

* At some font sizes, there is not much, if any spacing between the bookmark/folder title and the "edit" action button in the undo toast when the title is long

* When font size is large, the "Undo" button in the toast has a weird border that I don't see on other toasts with action buttons

Thanks Matt! Yeah definitely it should restore the recently saved folder. Theoretically if someone is pressing undo its because they've changed their mind about deletion and would like to return to the previous bookmarks state.

Also I'll take a look at the undo toast. I was using a pre-made component so I sort of assumed that it would be alright in terms of scaling.

[mergify]

This pull request has conflicts when rebasing. Could you fix it @DanielDervishi? 🙏

[MattLichtenstein]

Looks good, just one suggestion regarding formatting

[MattLichtenstein]

Should we move these tableView delegate functions down to where the other tableView functions are? I don't believe they belong under the actions mark

[DanielDervishi]

Yeah that's a good idea, I'll do that now