Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-9682 TabTrayStateTests #24235

Conversation

yusuphjoluwasen
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Added Test for TabTrayState
Added unit tests for TabTrayAction with TabTrayActionType:

  • didLoadTabTray
  • changePanel
  • dismissTabTray
  • firefoxAccountChanged

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@yusuphjoluwasen yusuphjoluwasen requested a review from a team as a code owner January 19, 2025 23:23
@FilippoZazzeroni FilippoZazzeroni self-requested a review January 20, 2025 09:09
Copy link
Collaborator

@FilippoZazzeroni FilippoZazzeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yusuphjoluwasen thanks a lot for the contribution you did great job 🎉 , only one side thing i see that some test cases are missing since TabTrayState is handling more cases, could you please add them. here is a list:

  • didChangePanel
  • refreshTabs
  • showToast
  • closeAllTabs
  • defaultState

@FilippoZazzeroni FilippoZazzeroni removed the request for review from mdotb-moz January 20, 2025 09:21
Copy link
Collaborator

@FilippoZazzeroni FilippoZazzeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great Thanks so much 🎉 i see only that defaultState is missing, i know you added testInitialState and it s great but default state it is a different method.

@FilippoZazzeroni FilippoZazzeroni self-requested a review January 21, 2025 15:42
Copy link
Contributor

mergify bot commented Jan 23, 2025

This pull request has conflicts when rebasing. Could you fix it @yusuphjoluwasen? 🙏

Copy link
Collaborator

@FilippoZazzeroni FilippoZazzeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks so much and great work 🎉 🎉 just a quick hint for next PRs try to avoid force push otherwise i don't see differences between previous commits.

@yusuphjoluwasen
Copy link
Contributor Author

Noted, Thanks

@FilippoZazzeroni
Copy link
Collaborator

FilippoZazzeroni commented Jan 24, 2025

@yusuphjoluwasen there are some lint issues, Do you mind solving them ? thanks so much 😃

@FilippoZazzeroni
Copy link
Collaborator

Hi @yusuphjoluwasen could you please update the PR to solve the swiftlint errors so we can merge it ? Thanks so much 😃

@yusuphjoluwasen yusuphjoluwasen deleted the FXIOS-21299-TabTrayStateTests branch January 30, 2025 17:22
@yusuphjoluwasen yusuphjoluwasen restored the FXIOS-21299-TabTrayStateTests branch January 30, 2025 17:24
@yusuphjoluwasen
Copy link
Contributor Author

yusuphjoluwasen commented Jan 30, 2025

Thanks @FilippoZazzeroni, I have fixed the SwiftLint errors and merged the main branch to prevent any merge conflicts. I also noticed that TabTrayState has been updated, so I went ahead and updated the unit tests accordingly to reflect those changes.

Copy link
Collaborator

@FilippoZazzeroni FilippoZazzeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks so much @yusuphjoluwasen great work 🎉 🎉

@FilippoZazzeroni FilippoZazzeroni changed the title Add FXIOS-21299 TabTrayStateTests Add FXIOS-9682 TabTrayStateTests Jan 31, 2025
@FilippoZazzeroni FilippoZazzeroni merged commit c9b7e01 into mozilla-mobile:main Jan 31, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants