-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FXIOS-9682 TabTrayStateTests #24235
Add FXIOS-9682 TabTrayStateTests #24235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yusuphjoluwasen thanks a lot for the contribution you did great job 🎉 , only one side thing i see that some test cases are missing since TabTrayState
is handling more cases, could you please add them. here is a list:
- didChangePanel
- refreshTabs
- showToast
- closeAllTabs
- defaultState
firefox-ios/firefox-ios-tests/Tests/ClientTests/TabTray/TabTrayStateTests.swift
Outdated
Show resolved
Hide resolved
firefox-ios/firefox-ios-tests/Tests/ClientTests/TabTray/TabTrayStateTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great Thanks so much 🎉 i see only that defaultState
is missing, i know you added testInitialState
and it s great but default state it is a different method.
firefox-ios/firefox-ios-tests/Tests/ClientTests/TabTray/TabTrayStateTests.swift
Outdated
Show resolved
Hide resolved
firefox-ios/firefox-ios-tests/Tests/ClientTests/TabTray/TabTrayStateTests.swift
Outdated
Show resolved
Hide resolved
firefox-ios/firefox-ios-tests/Tests/ClientTests/TabTray/TabTrayStateTests.swift
Outdated
Show resolved
Hide resolved
firefox-ios/firefox-ios-tests/Tests/ClientTests/TabTray/TabTrayStateTests.swift
Outdated
Show resolved
Hide resolved
firefox-ios/firefox-ios-tests/Tests/ClientTests/TabTray/TabTrayStateTests.swift
Outdated
Show resolved
Hide resolved
firefox-ios/firefox-ios-tests/Tests/ClientTests/TabTray/TabTrayStateTests.swift
Outdated
Show resolved
Hide resolved
This pull request has conflicts when rebasing. Could you fix it @yusuphjoluwasen? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks so much and great work 🎉 🎉 just a quick hint for next PRs try to avoid force push otherwise i don't see differences between previous commits.
Noted, Thanks |
@yusuphjoluwasen there are some lint issues, Do you mind solving them ? thanks so much 😃 |
Hi @yusuphjoluwasen could you please update the PR to solve the swiftlint errors so we can merge it ? Thanks so much 😃 |
Thanks @FilippoZazzeroni, I have fixed the SwiftLint errors and merged the main branch to prevent any merge conflicts. I also noticed that TabTrayState has been updated, so I went ahead and updated the unit tests accordingly to reflect those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect thanks so much @yusuphjoluwasen great work 🎉 🎉
📜 Tickets
Jira ticket
Github issue
💡 Description
Added Test for TabTrayState
Added unit tests for TabTrayAction with TabTrayActionType:
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)