Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-10711 Log event for tab loss bugs #24328

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mattreaganmozilla
Copy link
Collaborator

📜 Tickets

Jira ticket

💡 Description

Sentry log for tab_loss_detected event.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@mattreaganmozilla mattreaganmozilla requested a review from a team as a code owner January 24, 2025 21:04
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.21%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 32.28

File Coverage
TabErrorTelemetryHelper.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 7fa10f8

Copy link
Contributor

@yoanarios yoanarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fingers crossed to get better breadcrumbs and data

@mattreaganmozilla mattreaganmozilla merged commit c1a0e89 into mozilla-mobile:main Jan 27, 2025
10 checks passed
@mattreaganmozilla
Copy link
Collaborator Author

Going to create a backport for the next v135 weekly. This is not urgent, but it is low-risk and would be nice to get data sooner than later. (cc @rvandermeulen)

@mattreaganmozilla
Copy link
Collaborator Author

@Mergifyio backport release/v135

Copy link
Contributor

mergify bot commented Jan 27, 2025

backport release/v135

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 27, 2025
[FXIOS-10711] Fatal log for tab loss detected

(cherry picked from commit c1a0e89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants