[android 5] The insecure lock icon is white on the toolbar

[lobontiumira]

Steps to reproduce

1. On an Android 5 devices, install Focus, and set the Light theme.
2. Open an insecure page.
3. Observe the insecure lock icon from the toolbar.

Expected behavior

The insecure lock icon is visible.

Actual behavior

The insecure lock icon is white, and not visible.

Device information

• Android device: Samsung Galaxy Tab a6 (Android 5.1.1), Xiaomi mi4i (Android 5.0.2)
• Focus version: Beta 96.0.0-beta.1
• Not reproducible on Focus Nightly 95.0 (353421248 GV 96.0a1-20211204095400)

[ionutbedregeanu]

@lobontiumira Still reproducing? I tried on Pixel 5 Android 5.1 and I didn't succeed

[lobontiumira]

Yes, I am still able to reproduce this issue on Xiaomi mi4i (Android 5.0.2), on Focus Nightly 97.0 (build 360070846 GV 97.0a1-20220106155649):

[ionutbedregeanu]

mozilla-mobile/android-components#11537 should fix the bug

[Mugurell]

Looked into this more with Ionut and Mira and saw that this issue happens only after closing a tab, not with the first tab opened from a cold start and this seems like an intermittent issue, with cases in which this will work even in this scenario.

This seems to all depend on the fact that when a tab is closed we are resetting (clearing) the list of indicator and colors used for them and then seemingly there is an edgecase in which these are not properly updated when loading a new page.

[ionutbedregeanu]

To validate the fix we need to wait mozilla-mobile/android-components#11546 to be merged

[delia-pop]

This is fixed on Focus Nightly 98.0 (build 360280510 GV 98.0a1-20220127094620) with Huawei MediaPad M2 (Android 5.1.1).

Note that is still present in Beta 97.0.0-beta.6.