-
Notifications
You must be signed in to change notification settings - Fork 710
Issue #5935: Introduce setting for HTTPS-Only mode #5988
Conversation
Needs A-C build with mozilla-mobile/android-components#11352 |
For the preference: Should we have a "learn more" URL in settings like desktop? (Desktop page) / Preference placement: Like desktop, I created a "Security" section, that contains SafeBrowsing and this new setting. Is that okay? Looks good to me! This is only a minimal version of the error page compared to desktop - Have we ever thought of having a secondary CTA/link below like 'Manage your settings' where we can viewport them back to their security settings? What are your thoughts on setting the default state as toggled on to enhance the security experience for our users? Something we can probably discuss with the group in the weekly. |
That's an interesting idea. We would need to find a way to communicate this from our "error pages" component to the app. Not impossible. But something we need to figure out.
That sounds great. Yeah, let's discuss this. Maybe this requires us to change the error page text though. Otherwise the user may not really understand it, if they haven't enabled this themselves? 🤔 |
Updated the PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
@pocmo I worked with one of our content designers for strings updates: [Settings screen] [Error Page] |
@jeffreygee Awesome, thank you! I will work on getting this updated in #6009. |
This patch introduces HTTPS-Only mode. It's a draft.
CC @jeffreygee