This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
Update pending intent flags #6247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as draft because the app is still crashing
|
ionutbedregeanu
commented
Jan 18, 2022
app/src/main/java/org/mozilla/focus/session/SessionNotificationService.kt
Outdated
Show resolved
Hide resolved
Mugurell
reviewed
Jan 18, 2022
app/src/androidTest/java/org/mozilla/focus/activity/CustomTabTest.kt
Outdated
Show resolved
Hide resolved
ionutbedregeanu
force-pushed
the
ionut.bedregeanu/6244_startup_crash
branch
4 times, most recently
from
084ed31 to
fd12a4f
Compare
|
Tried out this patch with mozilla-mobile/android-components#11578 and it runs fine (tested with telemetry enabled too). EDIT: Added the patch to upgrade to the latest AC nightly and remove the |
Mugurell
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
Thanks @ionutbedregeanu and @jonalmeida for all the testing and work here!
Awesome to also see tests though it seems like we need to standardize an approach for running tests under different SDK_INT and probably should be part of a separate ticket.
Since Android 12 we need to set PendingIntent mutability explicitly, but Android 6 can be the minimum version This additional requirement improves your app's security. All pending intents are updated to contain also the flag FLAG_IMMUTABLE when the version of Android SDK is bigger than 30 FLAG_IMMUTABLE -> Flag indicating that the created PendingIntent should be immutable.
…sion At this moment WorkManager 2.4.0 doesn't have support for Android 12 so we are constrained to force import a newer version(2.7.0) This is a temporary solution until the version of WorkManager will be updated from AC
ionutbedregeanu
force-pushed
the
ionut.bedregeanu/6244_startup_crash
branch
from
08c2575 to
be219be
Compare
ionutbedregeanu
added
🛬 needs landing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6244
Since Android 12 we need to set PendingIntent mutability explicitly
This additional requirement improves your app's security.
All pending intents are updated to contain also the flag FLAG_IMMUTABLE when the version of
Android SDK is bigger than 30
FLAG_IMMUTABLE -> Flag indicating that the created PendingIntent should be immutable.
Pixel3a Api 29
api29.mp4
Pixel3a Api 31
api31.mp4
Pull Request checklist
To download an APK when reviewing a PR:
Show All Checks,Detailsnext tobuild-focus-debugorbuild-klar-debugfor changes targeting Klar,View task in Taskcluster,Artifactsrow,