Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

iOS App Store Connect issues sent via email for Focus/Klar #3466

Closed
dsmithpadilla opened this issue Sep 15, 2022 · 10 comments · Fixed by #3654
Closed

iOS App Store Connect issues sent via email for Focus/Klar #3466

dsmithpadilla opened this issue Sep 15, 2022 · 10 comments · Fixed by #3654
Assignees
Labels
Bug 🐞 qa-triaged Used by qa to triage incoming bugs from users

Comments

@dsmithpadilla
Copy link

dsmithpadilla commented Sep 15, 2022

We are receiving emails with iOS errors for every build submission to App Store Connect for Focus/Klar. This has been fixed for Fenix-ios here.

Most of the warnings relate to some localization problem with description & title on the customintent: 'Erase'. Example (but we get a warning for every locale):
ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: bn
ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: bg

┆Issue is synchronized with this Jira Task

@razvanlitianu
Copy link
Contributor

I was checking if we localize the intents and it seems that we already do. The strange thing is for some languages like Bulgarian the strings are different, for example from English. I know we don't modify the strings file directly, we get them from an import and I'm wondering what we missed. @Delphine do you have any ideas?

@Delphine
Copy link
Contributor

This is the first time I see such a thing! I honestly have no idea...
Talking with Flod, about the difference: you may need to remove all localized files and try importing from scratch. In fact the Bulgarian file hasn't been updated since 2018. Or it might be, once again, that Focus uses a different system than Firefox.
I see that for Fenix @isabelrios was involved. Maybe she has some tips for this?
I'm really sorry because otherwise, I don't know how to help at all, unfortunately :(

@isabelrios
Copy link
Collaborator

That was the first time I saw that too, I opened the issue and asked for developer's help. Laurie was able to fix that on Firefox-iOS, so we may need her help here. I think @razvanlitianu you mentioned in the last meeting that you were already talking to her, was it about this issue?

We can also try what @Delphine suggests, remove all localized files and importing from scratch...
Sorry I can't think about another solution :( but I will look into those files and try to understand the difference and if importing again could fix this.

@dsmithpadilla are you still receiving this messages?

@dsmithpadilla
Copy link
Author

Yes i still receive them everyday, one focus and one for klar. Laurie fixed it in mozilla-mobile/firefox-ios#11596 for Firefox-ios.

@razvanlitianu
Copy link
Contributor

Closing this for now. If it shows again in the AppStore Connect feel free to reopen and try to find another solution.

@dsmithpadilla
Copy link
Author

Unfortunately, I do not think that worked. Today I received the emails for Apple ID: 1073219424 Version: 9000 Build: 16549 which appears to be built off main in bitrise with this change. Can you confirm this change is included in that build?

@razvanlitianu
Copy link
Contributor

@dsmithpadilla Yes it was included but it didn't seem to work. I'll have another try with #3665 and hopefully it will be fixed.

@mergify mergify bot closed this as completed in 1823e4a Jan 18, 2023
@dsmithpadilla
Copy link
Author

Saw another push for this, but still seeing App Store Connect errors. :(

@abodea
Copy link
Member

abodea commented Jan 31, 2023

@dsmithpadilla should we re-open this?

@dsmithpadilla
Copy link
Author

@abodea i have not gotten an email since the 25th. Crossing fingers, but if I see these errors again, I'll re-open this ticket.

@abodea abodea added the qa-triaged Used by qa to triage incoming bugs from users label Feb 1, 2023
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this issue Feb 14, 2024
… via email for Focus/Klar (mozilla-mobile/focus-ios#3654)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this issue Feb 14, 2024
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this issue Feb 20, 2024
… issues sent via email for Focus/Klar (mozilla-mobile/focus-ios#3654)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this issue Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug 🐞 qa-triaged Used by qa to triage incoming bugs from users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants