Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ctest support for functional testing #10064

Merged
merged 14 commits into from
Nov 25, 2024
Merged

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Nov 22, 2024

Description

This is mostly just a minor annoyance that every time I have to run a functional test I have to remember and run a bunch of commands manually to get the functional testing envrionment setup. This makes it so that we can run a tests with something like the following:

  • ctest -L functional: Run all the functional tests
  • ctest -L unit: Run all the unit tests.
  • ctest -L auth: Run the authentication tests.
  • ctest -L qml: Run the QML tests.
  • ctest -R <test name>: Run a single test.

Reference

i.e Jira or Github issue URL

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@oskirby oskirby marked this pull request as ready for review November 23, 2024 01:52
Copy link
Collaborator

@strseb strseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the tag unit to mz_add_test_target aswell ? :)

@oskirby
Copy link
Collaborator Author

oskirby commented Nov 25, 2024

Uh oh, looks like the socksproxy tests don't pass on MacOS. Guess I should fix that first.

@strseb
Copy link
Collaborator

strseb commented Nov 25, 2024

Uh oh, looks like the socksproxy tests don't pass on MacOS. Guess I should fix that first.

Well we're not shipping that binary on macos, so i think you could just not compile+run the tests on macos.

Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Thanks!

This seems reasonable, though this area is not my expertise. I'd encourage waiting for at least one other approval.

@oskirby oskirby merged commit 68c9c62 into main Nov 25, 2024
94 of 95 checks passed
@oskirby oskirby deleted the ctest-functional-testing branch November 25, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants