Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN-5745 - Fix update message contents #8365

Merged
merged 1 commit into from
Oct 25, 2023
Merged

VPN-5745 - Fix update message contents #8365

merged 1 commit into from
Oct 25, 2023

Conversation

brizental
Copy link
Contributor

Tentative fix. Waiting for discussions on whether this is the change we want to go with.

@brizental brizental marked this pull request as ready for review October 23, 2023 15:40
@brizental brizental marked this pull request as draft October 23, 2023 16:16
@brizental
Copy link
Contributor Author

Apologies to the reviewers, moving this back to draft because turns out discussion were not over.

lesleyjanenorton
lesleyjanenorton approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@lesleyjanenorton lesleyjanenorton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to strange the IDs for each of these but otherwise R+

@brizental brizental marked this pull request as ready for review October 24, 2023 13:12
@brizental brizental merged commit 449da8a into main Oct 25, 2023
84 of 85 checks passed
@brizental brizental deleted the 5745-wrong-messages branch October 25, 2023 08:56
@brizental brizental mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesleyjanenorton lesleyjanenorton lesleyjanenorton approved these changes

@flodolo flodolo Awaiting requested review from flodolo flodolo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brizental @lesleyjanenorton