VPN-5005 - Add tests #8377
Closed
VPN-5005 - Add tests #8377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
force-pushed
the
5005-tests
branch
3 times, most recently
from
ea61ea7
to
7afa55f
Compare
brizental
force-pushed
the
5005-tests
branch
7 times, most recently
from
caecd61
to
0808954
Compare
These are the minimal semantic modules I had to separate in order to be able to create an isolated target to test the daemon stuff. I could have gone more minimal here, yes. However that would mean creating targets that don't necessarily make sense as a group of functionalities bundled together. Why do this at all? Currently, if we want to create an isolated test suite for a given module of this codebase we either have to re-add the exact set of files our isolated stuff will require to work and also all the dependencies these files have or... we have to import all of the shared-sources in the very least and also set up all the dependencies these sources have. The approach introduced in this commit, creates isolated buildable targets that can be linked to other isolated targets to create minimal buildable executables that only have the strictly necessary stuff for the bundle to build. This was done, as will become clear in the next commits, in order to create an executable for the daemon tests. The daemon includes leakdetector and logging. Most of the other stuff I modularized here was because of the dependencies of logging.
That was not necessary and also was colliding with the constants.cpp brought in by mozillavpn_environment
|
Failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending this partial to see what breaks on CI. This is not ready for review.