VPN-6151: Fix vertical alignment of text in controller view #9321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Short story: This PR makes a two line tweak to the controller view to fix VPN-6151.
Longer story: Depending on the locale, text in the controller view occasionally changes from a single line to multiple lines when connecting/disconnecting and requires 'special handling' to maintain evenly distributed vertical space without repositioning the vpn toggle button and changing the overall size of the containing purple background square. At some point in quasi-recent history, that handling was dropped for the controller subtitle text (but only when the VPN is on). This PR restores that handling so that the subtitle text can reposition itself correctly.
Reference
VPN-6151
Checklist