Nit: [Sentry] - Pass version using semver #9501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strseb
force-pushed
the
basti/fix_sentry_semver
branch
from
7afe602
to
cdb897d
Compare
oskirby
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One annoying thing right now is that sentry does not parse our versions. So if we mark something fixed on 2.23 (which is on stage) but we push a 2.22.1 hotfix still with that bug, the bug will be re-opened until a newer release is created.
That is because sentry currently goes by "when was this release first seen" vs "what does the number say".
For that we need to pass that string formatted using semver.
With that pr i created a test crash: see semver is now "yes" for 2.23.
https://mozilla.sentry.io/releases/mozilla-vpn%402.23.0/?project=4504197915607040