Reduce warnings in GitHub workflows #9520
Conversation
flodolo
force-pushed
the
update_workflows
branch
3 times, most recently
from
cc7c4ff to
c4fdc3f
Compare
| @@ -167,7 +167,7 @@ jobs: | |||
| -o ${{ runner.temp }}/artifacts/functional_lcov.info | |||
|
|
|||
| - name: Upload coverage to Codecov | |||
| uses: codecov/codecov-action@v3 | |||
| uses: codecov/codecov-action@v4 | |||
There was a problem hiding this comment.
Apparently Codecov requires a token: codecov/codecov-action#1274 (comment)
There was a problem hiding this comment.
Someone needs to set up a secret (I have access to the key in Codecov, but not this repo).
https://docs.codecov.com/docs/adding-the-codecov-token#github-actions
There was a problem hiding this comment.
Honestly, we should just strip out the codecov checks, they haven't worked since Raphael left the team.
There was a problem hiding this comment.
Let me know if I should remove these steps, or merge this as is ;-)
There was a problem hiding this comment.
Merge it as-is. I can follow up with another PR to strip out the codecov stuff.
flodolo
force-pushed
the
update_workflows
branch
3 times, most recently
from
b74147e to
bfc557a
Compare
This error is not due to updates, it's been there all the time (macOS tests). It's possible to set the action to not produce warnings, but someone needs to confirm if that's wanted behavior or not (no idea what should be in these folders). |
flodolo
changed the title
| @@ -130,7 +132,7 @@ jobs: | |||
| MVPN_BIN: ./build/dummyvpn | |||
|
|
|||
| - name: Uploading artifacts | |||
There was a problem hiding this comment.
I couldn't help noticing that this looks very similar to the Linux workflow, which doesn't fail.
That workflow has an additional step though, using the same artifacts folder, so that might be the reason?
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4
if: steps.generateGrcov.outcome == 'success'
with:
directory: .
flags: functional_tests
name: codecov-poc
files: ${{ runner.temp }}/artifacts/functional_lcov.info
verbose: true
There are currently over 100 warnings in checks, mostly due to obsolete GitHub actions.