try to fix qml imports #9561
Merged
try to fix qml imports #9561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should undo the NO_PLUGIN_OPTIONAL thing I did before if this is the fix. |
lesleyjanenorton
approved these changes
May 14, 2024
There was a problem hiding this comment.
Do we still need the NO_PLUGIN_OPTIONAL change from #9531 ?
|
This works for me on Android for 6.6. Thanks! |
|
Works for my MacOS machine (tested both Qt 6.2.4 and Qt 6.6.3). |
oskirby
approved these changes
May 14, 2024
There was a problem hiding this comment.
As a thought for some future cleanup - we don't really need to use the path so prominently and in many cases we can load QML objects by type rather than URL.
For example, a StackView::push() can accept an Item, Component or url so in theory something like stackView.push(ViewAboutUs{..}) should work too.
But that's too much work for now. Let's merge this and get the breakage fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
i do think setting the policy to OLD broke things, my bad 🙏 .
-> So let's keep it at new and backport the changes of this policy to 6.2.4
->Set the resource prefix
/qt/qml, it's the default value after 6.5-> Add
/qt/qmlto the path by default.This seems to fix everything on Windows (6.2.4/6.6.0) tested.