VPN-6363: Better LAN exclusions #9674
Merged
firefoxci-taskcluster / source-test-clang-tidy-macos
succeeded
Jul 23, 2024 in 10m 37s
FirefoxCI (pull_request)
Clang-tidy (Treeherder push)
Details
View task in Taskcluster
View logs in Taskcluster
[task 2024-07-23T16:13:44.790Z] # include <signal.h>
[task 2024-07-23T16:13:44.790Z] ^~~~~~~~~~
[task 2024-07-23T16:13:44.790Z] <csignal>
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/localsocketcontroller.cpp:41:46: warning: pass by value and use std::move [modernize-pass-by-value]
[task 2024-07-23T16:13:44.790Z] LocalSocketController::LocalSocketController(const QString& path)
[task 2024-07-23T16:13:44.790Z] ^~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.790Z] QString
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/localsocketcontroller.cpp:330:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-07-23T16:13:44.790Z] QTimer* t = new QTimer(this);
[task 2024-07-23T16:13:44.790Z] ^~~~~~
[task 2024-07-23T16:13:44.790Z] auto
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/localsocketcontroller.cpp:409:3: warning: do not declare C-style arrays, use std::array<> instead [modernize-avoid-c-arrays]
[task 2024-07-23T16:13:44.790Z] char killpath[] = "/bin/kill";
[task 2024-07-23T16:13:44.790Z] ^
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/localsocketcontroller.cpp:410:3: warning: do not declare C-style arrays, use std::array<> instead [modernize-avoid-c-arrays]
[task 2024-07-23T16:13:44.790Z] char killsignal[] = "-SEGV";
[task 2024-07-23T16:13:44.790Z] ^
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/localsocketcontroller.cpp:411:3: warning: do not declare C-style arrays, use std::array<> instead [modernize-avoid-c-arrays]
[task 2024-07-23T16:13:44.790Z] char* const killargs[] = {killsignal, pidString.data(), nullptr};
[task 2024-07-23T16:13:44.790Z] ^
[task 2024-07-23T16:13:44.790Z] 7778 warnings generated.
[task 2024-07-23T16:13:44.790Z] Suppressed 7772 warnings (7772 in non-user code).
[task 2024-07-23T16:13:44.790Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmp2j4128e5.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/platforms/dummy/dummynetworkwatcher.cpp
[task 2024-07-23T16:13:44.790Z] 4432 warnings generated.
[task 2024-07-23T16:13:44.790Z] Suppressed 4432 warnings (4432 in non-user code).
[task 2024-07-23T16:13:44.790Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmpto7cv117.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/ipaddresslookup.cpp
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/ipaddresslookup.cpp:63:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-07-23T16:13:44.790Z] TaskIPFinder* ipfinder = new TaskIPFinder();
[task 2024-07-23T16:13:44.790Z] ^~~~~~~~~~~~
[task 2024-07-23T16:13:44.790Z] auto
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/fetches/qt_dist/include/QtCore/qtimer.h:77:5: warning: Potential memory leak [clang-analyzer-cplusplus.NewDeleteLeaks]
[task 2024-07-23T16:13:44.790Z] }
[task 2024-07-23T16:13:44.790Z] ^
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/ipaddresslookup.cpp:67:13: note: Assuming the condition is false
[task 2024-07-23T16:13:44.790Z] if (ipv4.isEmpty() && ipv6.isEmpty()) {
[task 2024-07-23T16:13:44.790Z] ^~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/ipaddresslookup.cpp:67:28: note: Left side of '&&' is false
[task 2024-07-23T16:13:44.790Z] if (ipv4.isEmpty() && ipv6.isEmpty()) {
[task 2024-07-23T16:13:44.790Z] ^
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/ipaddresslookup.cpp:81:9: note: Taking true branch
[task 2024-07-23T16:13:44.790Z] if (country != MozillaVPN::instance()
[task 2024-07-23T16:13:44.790Z] ^
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/ipaddresslookup.cpp:88:11: note: Calling 'QTimer::singleShot'
[task 2024-07-23T16:13:44.790Z] QTimer::singleShot(3000, this, [this]() {
[task 2024-07-23T16:13:44.790Z] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/fetches/qt_dist/include/QtCore/qtimer.h:63:9: note: Calling 'QTimer::singleShot'
[task 2024-07-23T16:13:44.790Z] singleShot(interval, defaultTypeFor(interval), receiver, std::forward<Functor>(slot));
[task 2024-07-23T16:13:44.790Z] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/fetches/qt_dist/include/QtCore/qtimer.h:76:24: note: Calling 'makeCallableObject<void (*)(), (lambda at /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/ipaddresslookup.cpp:88:42)>'
[task 2024-07-23T16:13:44.790Z] QtPrivate::makeCallableObject<Prototype>(std::forward<Functor>(slot)));
[task 2024-07-23T16:13:44.790Z] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.790Z] 7546 warnings generated.
[task 2024-07-23T16:13:44.790Z] Suppressed 7545 warnings (7544 in non-user code, 1 NOLINT).
[task 2024-07-23T16:13:44.790Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmp4cv0rx02.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/devicemodel.cpp
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/devicemodel.cpp:136:13: warning: prefer a lambda to std::bind [modernize-avoid-bind]
[task 2024-07-23T16:13:44.790Z] std::bind(sortCallback, std::placeholders::_1,
[task 2024-07-23T16:13:44.790Z] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.790Z] [keys](auto && PH1, auto && PH2) { return sortCallback(std::forward<decltype(PH1)>(PH1), std::forward<decltype(PH2)>(PH2), keys); }
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/devicemodel.cpp:164:12: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.790Z] return QVariant();
[task 2024-07-23T16:13:44.790Z] ^~~~~~~~~~
[task 2024-07-23T16:13:44.790Z] {}
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/devicemodel.cpp:169:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.790Z] return QVariant(m_devices.at(index.row()).name());
[task 2024-07-23T16:13:44.790Z] ^
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/devicemodel.cpp:172:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.790Z] return QVariant(m_devices.at(index.row()).publicKey());
[task 2024-07-23T16:13:44.790Z] ^
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/devicemodel.cpp:175:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.790Z] return QVariant(m_devices.at(index.row())
[task 2024-07-23T16:13:44.790Z] ^~~~~~~~~
[task 2024-07-23T16:13:44.790Z] {
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/devicemodel.cpp:179:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.790Z] return QVariant(m_devices.at(index.row()).createdAt());
[task 2024-07-23T16:13:44.790Z] ^
[task 2024-07-23T16:13:44.790Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/devicemodel.cpp:182:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.791Z] return QVariant();
[task 2024-07-23T16:13:44.791Z] ^~~~~~~~~~
[task 2024-07-23T16:13:44.791Z] {}
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/devicemodel.cpp:211:17: warning: prefer a lambda to std::bind [modernize-avoid-bind]
[task 2024-07-23T16:13:44.791Z] std::bind(sortCallback, std::placeholders::_1,
[task 2024-07-23T16:13:44.791Z] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.791Z] [keys](auto && PH1, auto && PH2) { return sortCallback(std::forward<decltype(PH1)>(PH1), std::forward<decltype(PH2)>(PH2), keys); }
[task 2024-07-23T16:13:44.791Z] 9863 warnings generated.
[task 2024-07-23T16:13:44.791Z] Suppressed 9855 warnings (9855 in non-user code).
[task 2024-07-23T16:13:44.791Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmpy5ey5d2x.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/statusicon.cpp
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/statusicon.cpp:180:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.791Z] return QIcon(iconPixmap);
[task 2024-07-23T16:13:44.791Z] ^
[task 2024-07-23T16:13:44.791Z] 9576 warnings generated.
[task 2024-07-23T16:13:44.791Z] Suppressed 9575 warnings (9575 in non-user code).
[task 2024-07-23T16:13:44.791Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmpmvvgw_cq.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/mozillavpn.cpp
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/mozillavpn.cpp:470:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-07-23T16:13:44.791Z] TaskAuthenticate* taskAuthenticate = new TaskAuthenticate(authenticationType);
[task 2024-07-23T16:13:44.791Z] ^~~~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.791Z] auto
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/mozillavpn.cpp:678:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-07-23T16:13:44.791Z] QString* buffer = new QString();
[task 2024-07-23T16:13:44.791Z] ^~~~~~~
[task 2024-07-23T16:13:44.791Z] auto
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/mozillavpn.cpp:679:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-07-23T16:13:44.791Z] QTextStream* out = new QTextStream(buffer);
[task 2024-07-23T16:13:44.791Z] ^~~~~~~~~~~
[task 2024-07-23T16:13:44.791Z] auto
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/mozillavpn.cpp:1221:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-07-23T16:13:44.791Z] TaskDeleteAccount* task = new TaskDeleteAccount(m_private->m_user.email());
[task 2024-07-23T16:13:44.791Z] ^~~~~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.791Z] auto
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/mozillavpn.cpp:1744:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-07-23T16:13:44.791Z] NavigationBarButton* messageIcon = new NavigationBarButton(
[task 2024-07-23T16:13:44.791Z] ^~~~~~~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.791Z] auto
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/fetches/qt_dist/include/QtCore/qtimer.h:77:5: warning: Potential memory leak [clang-analyzer-cplusplus.NewDeleteLeaks]
[task 2024-07-23T16:13:44.791Z] }
[task 2024-07-23T16:13:44.791Z] ^
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/mozillavpn.cpp:815:3: note: Calling 'QTimer::singleShot'
[task 2024-07-23T16:13:44.791Z] QTimer::singleShot(0, this, &MozillaVPN::initializeGlean);
[task 2024-07-23T16:13:44.791Z] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/fetches/qt_dist/include/QtCore/qtimer.h:63:9: note: Calling 'QTimer::singleShot'
[task 2024-07-23T16:13:44.791Z] singleShot(interval, defaultTypeFor(interval), receiver, std::forward<Functor>(slot));
[task 2024-07-23T16:13:44.791Z] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/fetches/qt_dist/include/QtCore/qtimer.h:76:24: note: Calling 'makeCallableObject<void (*)(), void (MozillaVPN::*)()>'
[task 2024-07-23T16:13:44.791Z] QtPrivate::makeCallableObject<Prototype>(std::forward<Functor>(slot)));
[task 2024-07-23T16:13:44.791Z] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.791Z] 14959 warnings generated.
[task 2024-07-23T16:13:44.791Z] Suppressed 14954 warnings (14953 in non-user code, 1 NOLINT).
[task 2024-07-23T16:13:44.791Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmptolw56l6.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/commands/commandactivate.cpp
[task 2024-07-23T16:13:44.791Z] 7246 warnings generated.
[task 2024-07-23T16:13:44.791Z] Suppressed 7246 warnings (7246 in non-user code).
[task 2024-07-23T16:13:44.791Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmpqq6eqxq6.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/location.cpp
[task 2024-07-23T16:13:44.791Z] 5821 warnings generated.
[task 2024-07-23T16:13:44.791Z] Suppressed 5821 warnings (5821 in non-user code).
[task 2024-07-23T16:13:44.791Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmp3sw01ip6.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/systemtraynotificationhandler.cpp
[task 2024-07-23T16:13:44.791Z] 8283 warnings generated.
[task 2024-07-23T16:13:44.791Z] Suppressed 8283 warnings (8283 in non-user code).
[task 2024-07-23T16:13:44.791Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmp0v6zlw5q.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/constants.cpp
[task 2024-07-23T16:13:44.791Z] 8004 warnings generated.
[task 2024-07-23T16:13:44.791Z] Suppressed 8004 warnings (8004 in non-user code).
[task 2024-07-23T16:13:44.791Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmpe002cm2h.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/tasks/heartbeat/taskheartbeat.cpp
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/tasks/heartbeat/taskheartbeat.cpp:27:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-07-23T16:13:44.791Z] NetworkRequest* request = new NetworkRequest(this, 200);
[task 2024-07-23T16:13:44.791Z] ^~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.791Z] auto
[task 2024-07-23T16:13:44.791Z] 6842 warnings generated.
[task 2024-07-23T16:13:44.791Z] Suppressed 6841 warnings (6841 in non-user code).
[task 2024-07-23T16:13:44.791Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmpia0ytcbz.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/recentconnections.cpp
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/recentconnections.cpp:168:12: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.791Z] return QVariant();
[task 2024-07-23T16:13:44.791Z] ^~~~~~~~~~
[task 2024-07-23T16:13:44.791Z] {}
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/recentconnections.cpp:173:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.791Z] return QVariant(m_list.at(id).m_exitCountryCode);
[task 2024-07-23T16:13:44.791Z] ^
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/recentconnections.cpp:176:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.791Z] return QVariant(m_list.at(id).m_exitCityName);
[task 2024-07-23T16:13:44.791Z] ^
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/recentconnections.cpp:180:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.791Z] return QVariant(
[task 2024-07-23T16:13:44.791Z] ^
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/recentconnections.cpp:186:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.791Z] return QVariant(!rc.m_entryCountryCode.isEmpty() &&
[task 2024-07-23T16:13:44.791Z] ^~~~~~~~~
[task 2024-07-23T16:13:44.791Z] {
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/recentconnections.cpp:191:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.791Z] return QVariant(m_list.at(id).m_entryCountryCode);
[task 2024-07-23T16:13:44.791Z] ^
[task 2024-07-23T16:13:44.791Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/recentconnections.cpp:194:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.792Z] return QVariant(m_list.at(id).m_entryCityName);
[task 2024-07-23T16:13:44.792Z] ^
[task 2024-07-23T16:13:44.792Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/recentconnections.cpp:198:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.792Z] return QVariant(
[task 2024-07-23T16:13:44.792Z] ^
[task 2024-07-23T16:13:44.792Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/models/recentconnections.cpp:203:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.792Z] return QVariant();
[task 2024-07-23T16:13:44.792Z] ^~~~~~~~~~
[task 2024-07-23T16:13:44.792Z] {}
[task 2024-07-23T16:13:44.792Z] 10074 warnings generated.
[task 2024-07-23T16:13:44.792Z] Suppressed 10065 warnings (10065 in non-user code).
[task 2024-07-23T16:13:44.792Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.792Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmpqpmp1je_.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/daemon/daemonlocalserverconnection.cpp
[task 2024-07-23T16:13:44.792Z] 6107 warnings generated.
[task 2024-07-23T16:13:44.792Z] Suppressed 6107 warnings (6107 in non-user code).
[task 2024-07-23T16:13:44.792Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.792Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmp0vuxxx36.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/purchaseiaphandler.cpp
[task 2024-07-23T16:13:44.792Z] 5345 warnings generated.
[task 2024-07-23T16:13:44.792Z] Suppressed 5345 warnings (5345 in non-user code).
[task 2024-07-23T16:13:44.792Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.792Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmpx75mj4j9.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/captiveportal/captiveportaldetectionimpl.cpp
[task 2024-07-23T16:13:44.792Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/captiveportal/captiveportaldetectionimpl.cpp:27:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-07-23T16:13:44.792Z] CaptivePortalRequestTask* task = new CaptivePortalRequestTask();
[task 2024-07-23T16:13:44.792Z] ^~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.792Z] auto
[task 2024-07-23T16:13:44.792Z] 4658 warnings generated.
[task 2024-07-23T16:13:44.792Z] Suppressed 4657 warnings (4657 in non-user code).
[task 2024-07-23T16:13:44.792Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.792Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmpmmv6ev_f.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/controller.cpp
[task 2024-07-23T16:13:44.792Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/controller.cpp:128:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-07-23T16:13:44.792Z] return QString();
[task 2024-07-23T16:13:44.792Z] ^~~~~~~~~
[task 2024-07-23T16:13:44.792Z] {}
[task 2024-07-23T16:13:44.792Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/controller.cpp:1004:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-07-23T16:13:44.792Z] TaskFunction* task = new TaskFunction([]() {});
[task 2024-07-23T16:13:44.792Z] ^~~~~~~~~~~~
[task 2024-07-23T16:13:44.792Z] auto
[task 2024-07-23T16:13:44.792Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/controller.cpp:1005:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-07-23T16:13:44.792Z] NetworkRequest* request = new NetworkRequest(task, 200);
[task 2024-07-23T16:13:44.792Z] ^~~~~~~~~~~~~~
[task 2024-07-23T16:13:44.792Z] auto
[task 2024-07-23T16:13:44.792Z] 12168 warnings generated.
[task 2024-07-23T16:13:44.792Z] Suppressed 12165 warnings (12165 in non-user code).
[task 2024-07-23T16:13:44.792Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.792Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmpbxwj2y26.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/telemetry.cpp
[task 2024-07-23T16:13:44.792Z] 11726 warnings generated.
[task 2024-07-23T16:13:44.792Z] Suppressed 11726 warnings (11726 in non-user code).
[task 2024-07-23T16:13:44.792Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.792Z] /opt/worker/tasks/task_171210569248981/fetches/bin/clang-tidy -export-fixes /tmp/tmp2eq_ms6l/tmpj9aybq_j.yaml -p=/opt/worker/tasks/task_171210569248981/build /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/notificationhandler.cpp
[task 2024-07-23T16:13:44.792Z] /opt/worker/tasks/task_171210569248981/checkouts/vcs/src/notificationhandler.cpp:402:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
[task 2024-07-23T16:13:44.792Z] AddonMessage* addonMessage = qobject_cast<AddonMessage*>(addon);
[task 2024-07-23T16:13:44.792Z] ^~~~~~~~~~~~
[task 2024-07-23T16:13:44.792Z] auto
[task 2024-07-23T16:13:44.792Z] 10651 warnings generated.
[task 2024-07-23T16:13:44.792Z] Suppressed 10650 warnings (10650 in non-user code).
[task 2024-07-23T16:13:44.792Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-07-23T16:13:44.792Z] Writing fixes to /opt/worker/tasks/task_171210569248981/build/clang-tidy/mozillavpn-sources-report.yaml ...
[task 2024-07-23T16:13:44.792Z] + rm -rf /opt/worker/tasks/task_171210569248981/build
[fetches 2024-07-23T16:13:47.233Z] removing /opt/worker/tasks/task_171210569248981/fetches
[fetches 2024-07-23T16:13:59.588Z] finished
[taskcluster 2024-07-23T16:13:59.601Z] Exit Code: 0
[taskcluster 2024-07-23T16:13:59.601Z] User Time: 1h6m48.455172s
[taskcluster 2024-07-23T16:13:59.601Z] Kernel Time: 3m49.7569s
[taskcluster 2024-07-23T16:13:59.601Z] Wall Time: 10m29.362316s
[taskcluster 2024-07-23T16:13:59.601Z] Result: SUCCEEDED
[taskcluster 2024-07-23T16:13:59.602Z] === Task Finished ===
[taskcluster 2024-07-23T16:13:59.602Z] Task Duration: 10m29.366621s
[taskcluster 2024-07-23T16:13:59.697Z] Uploading artifact public/logs/certified.log from file /opt/worker/tasks/task_171210569248981/generic-worker/certified.log with content encoding "gzip", mime type "text/plain; charset=utf-8" and expiry 2024-08-20T16:03:23.136Z
[taskcluster 2024-07-23T16:14:00.051Z] Uploading artifact public/chain-of-trust.json from file /opt/worker/tasks/task_171210569248981/generic-worker/chain-of-trust.json with content encoding "gzip", mime type "text/plain; charset=utf-8" and expiry 2024-08-20T16:03:23.136Z
[taskcluster 2024-07-23T16:14:00.339Z] Uploading artifact public/chain-of-trust.json.sig from file /opt/worker/tasks/task_171210569248981/generic-worker/chain-of-trust.json.sig with content encoding "gzip", mime type "application/octet-stream" and expiry 2024-08-20T16:03:23.136Z
[taskcluster 2024-07-23T16:14:00.615Z] Uploading link artifact public/logs/live.log to artifact public/logs/live_backing.log with expiry 2024-08-20T16:03:23.136Z
Loading