Nit: Make ProxyController a featureflag #9771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskirby
reviewed
Aug 6, 2024
src/feature/featurelist.h
Outdated
| "LocalProxy", // Feature name | ||
| FeatureCallback_proxyCanTurnOn, // Can be flipped on | ||
| FeatureCallback_true, // Can be flipped off | ||
| QStringList(), // feature dependencies |
There was a problem hiding this comment.
Shouldn't this have a dependency on split tunnelling?
oskirby
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The local proxy currently is a bit hard to enable:
-> You need to be in stage mode
-> you need split tunnel
-> you need to have the binary in a certain place.
And if one of those fails, we silently fail.
Let's make it a featureflag, with the precondition of "is windows | linux" and use the featureflag mechanism to allow it to turn it on, make it default on in stage :)
This also makes it look on "Debug" builds inside the build dir instead of an "install" like folder, making setup better.
Also add logs if things fail so people can self troubleshoot.