VPN-6448 try to scheudle a reboot on w10 (2.24 only) #9809
Conversation
strseb
changed the title
strseb
changed the title
There was a problem hiding this comment.
I guess we don't technically need to solve this now, but as-written this installer file will always reboot for Windows 10 users. However, in the future when users are upgrading say from 2.24 -> 2.25 that reboot is no longer required, but the installer will still force it.
In order to minimize inconvenience to our users, it would be nice if this reboot could be made conditional upon the previously installed VPN version.
| <Custom Action="LaunchVPNFirstExecution" After="InstallFinalize">NOT WIX_UPGRADE_DETECTED</Custom> | ||
| <Custom Action="LaunchVPNAfterUpdate" After="InstallFinalize">WIX_UPGRADE_DETECTED</Custom> | ||
| <!-- This will schedule a reboot only if the OS is Windows 10 --> | ||
| <ScheduleReboot After="InstallFinalize"> |
There was a problem hiding this comment.
As I understand this, it will schedule a reboot after both fresh installs and upgrades even though we only need it on upgrades. It's not really the worst outcome, just inconvenient.
Ah dang i filed it against main, i actually just wanted this to land on the 2.24 branch. |
strseb
force-pushed
the
basti/w10reboot
branch
from
d14a833
to
5ffff0d
Compare
strseb
changed the title
Description
Given QA's ticket mentions they uninstall the old version, using wix_upgrade detected is not sufficient. So let's just "ask" w10 users to reboot after installation :)