Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: Pass connectionhealth status to Extension #9854

Merged
merged 9 commits into from
Sep 24, 2024
Merged

Conversation

strseb
Copy link
Collaborator

@strseb strseb commented Sep 9, 2024

Description

In order to show connection health things in the extension, we should pass that info first.

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozillavpn-level-1/F1XmGhPwTkC7Y2mU7YIjrw/Ap6SpUXqSdi5JbhQT18plQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozillavpn-level-1/F1XmGhPwTkC7Y2mU7YIjrw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozillavpn-level-1/F1XmGhPwTkC7Y2mU7YIjrw/Ap6SpUXqSdi5JbhQT18plQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozillavpn-level-1/F1XmGhPwTkC7Y2mU7YIjrw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2024-09-12T00:24:12.139Z

strseb added a commit to mozilla-extensions/mozilla-vpn-extension that referenced this pull request Sep 24, 2024
Depends on:
mozilla-mobile/mozilla-vpn-client#9854

Add's a stability attribute for the `<vpn-card>` element. Swapping out
the time string for that status.


https://github.com/user-attachments/assets/61ebe3b5-86d7-4a3b-baca-7420737ec568
@strseb strseb merged commit ac3ccf6 into main Sep 24, 2024
116 checks passed
@strseb strseb deleted the basti/connectionHealth branch September 24, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants