Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors from deprecated QByteArray::count(), QVariant::type(), QEventPoint::pos() #9961

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Fix build errors from deprecated QEventPoint::pos and friends

10b1c98
Select commit
Loading
Failed to load commit list.
Open

Fix build errors from deprecated QByteArray::count(), QVariant::type(), QEventPoint::pos() #9961

Fix build errors from deprecated QEventPoint::pos and friends
10b1c98
Select commit
Loading
Failed to load commit list.
firefoxci-taskcluster / source-test-clang-tidy-macos succeeded Oct 15, 2024 in 9m 58s

FirefoxCI (pull_request)

Clang-tidy (Treeherder push)

Details

View task in Taskcluster | View logs in Taskcluster | View task group in Taskcluster

Task Status

Started: 2024-10-15T22:34:57.683Z
Resolved: 2024-10-15T22:44:52.555Z
Task Execution Time: 9 minutes, 54 seconds, 872 milliseconds
Task Status: completed
Reason Resolved: completed
RunId: 0

Artifacts

- public/chain-of-trust.json
- public/chain-of-trust.json.sig
- public/logs/certified.log
- public/logs/live_backing.log
- public/logs/live.log


[taskcluster 2024-10-15T22:34:57.577Z] Worker Type (releng-hardware/mozillavpn-b-1-osx) settings:
[taskcluster 2024-10-15T22:34:57.577Z]   {
[taskcluster 2024-10-15T22:34:57.577Z]     "arch": "x86_64",
[taskcluster 2024-10-15T22:34:57.577Z]     "config": {
[taskcluster 2024-10-15T22:34:57.577Z]       "deploymentId": ""
[taskcluster 2024-10-15T22:34:57.577Z]     },
[taskcluster 2024-10-15T22:34:57.577Z]     "disk_size": "233.47 GiB",
[taskcluster 2024-10-15T22:34:57.577Z]     "generic-worker": {
[taskcluster 2024-10-15T22:34:57.577Z]       "engine": "multiuser",
[taskcluster 2024-10-15T22:34:57.577Z]       "go-arch": "amd64",
[taskcluster 2024-10-15T22:34:57.577Z]       "go-os": "darwin",
[taskcluster 2024-10-15T22:34:57.577Z]       "go-version": "go1.22.0",
[taskcluster 2024-10-15T22:34:57.577Z]       "release": "https://github.com/taskcluster/taskcluster/releases/tag/v60.3.4",
[taskcluster 2024-10-15T22:34:57.577Z]       "revision": "943a6f2b0d14fa0270280bc6f23acc2945d0fe45",
[taskcluster 2024-10-15T22:34:57.577Z]       "source": "https://github.com/taskcluster/taskcluster/commits/943a6f2b0d14fa0270280bc6f23acc2945d0fe45",
[taskcluster 2024-10-15T22:34:57.577Z]       "version": "60.3.4"
[taskcluster 2024-10-15T22:34:57.577Z]     },
[taskcluster 2024-10-15T22:34:57.577Z]     "ip": "10.49.59.31",
[taskcluster 2024-10-15T22:34:57.577Z]     "machine-setup": {
[taskcluster 2024-10-15T22:34:57.577Z]       "config": "https://github.com/mozilla-platform-ops/ronin_puppet"

...(4333 lines hidden)...

[task 2024-10-15T22:44:36.979Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmp22gd8t5c.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/systemtraynotificationhandler.cpp
[task 2024-10-15T22:44:36.979Z] 8285 warnings generated.
[task 2024-10-15T22:44:36.979Z] Suppressed 8285 warnings (8285 in non-user code).
[task 2024-10-15T22:44:36.979Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmpysf_31yp.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/platforms/dummy/dummyapplistprovider.cpp
[task 2024-10-15T22:44:36.979Z] 6613 warnings generated.
[task 2024-10-15T22:44:36.979Z] Suppressed 6613 warnings (6613 in non-user code).
[task 2024-10-15T22:44:36.979Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmp1nu7eta8.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/purchasewebhandler.cpp
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/purchasewebhandler.cpp:41:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-10-15T22:44:36.979Z]   TaskAuthenticate* taskAuthenticate =
[task 2024-10-15T22:44:36.979Z]   ^~~~~~~~~~~~~~~~
[task 2024-10-15T22:44:36.979Z]   auto
[task 2024-10-15T22:44:36.979Z] 6773 warnings generated.
[task 2024-10-15T22:44:36.979Z] Suppressed 6772 warnings (6772 in non-user code).
[task 2024-10-15T22:44:36.979Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmpvn71kkv3.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/platforms/dummy/dummypingsender.cpp
[task 2024-10-15T22:44:36.979Z] 4900 warnings generated.
[task 2024-10-15T22:44:36.979Z] Suppressed 4900 warnings (4900 in non-user code).
[task 2024-10-15T22:44:36.979Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmpkgttgw2j.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/mozillavpn_p.cpp
[task 2024-10-15T22:44:36.979Z] 8418 warnings generated.
[task 2024-10-15T22:44:36.979Z] Suppressed 8418 warnings (8418 in non-user code).
[task 2024-10-15T22:44:36.979Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmpum83prp2.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/purchasehandler.cpp
[task 2024-10-15T22:44:36.979Z] 5377 warnings generated.
[task 2024-10-15T22:44:36.979Z] Suppressed 5377 warnings (5377 in non-user code).
[task 2024-10-15T22:44:36.979Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmpghm5v4fw.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/tasks/release/taskrelease.cpp
[task 2024-10-15T22:44:36.979Z] 5806 warnings generated.
[task 2024-10-15T22:44:36.979Z] Suppressed 5806 warnings (5806 in non-user code).
[task 2024-10-15T22:44:36.979Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmpn4qnc0l8.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/commands/commandexcludeip.cpp
[task 2024-10-15T22:44:36.979Z] 9218 warnings generated.
[task 2024-10-15T22:44:36.979Z] Suppressed 9218 warnings (9218 in non-user code).
[task 2024-10-15T22:44:36.979Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmprev68yyh.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/localsocketcontroller.cpp
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/localsocketcontroller.cpp:7:10: warning: inclusion of deprecated C++ header 'stdint.h'; consider using 'cstdint' instead [modernize-deprecated-headers]
[task 2024-10-15T22:44:36.979Z] #include <stdint.h>
[task 2024-10-15T22:44:36.979Z]          ^~~~~~~~~~
[task 2024-10-15T22:44:36.979Z]          <cstdint>
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/localsocketcontroller.cpp:22:12: warning: inclusion of deprecated C++ header 'signal.h'; consider using 'csignal' instead [modernize-deprecated-headers]
[task 2024-10-15T22:44:36.979Z] #  include <signal.h>
[task 2024-10-15T22:44:36.979Z]            ^~~~~~~~~~
[task 2024-10-15T22:44:36.979Z]            <csignal>
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/localsocketcontroller.cpp:45:46: warning: pass by value and use std::move [modernize-pass-by-value]
[task 2024-10-15T22:44:36.979Z] LocalSocketController::LocalSocketController(const QString& path)
[task 2024-10-15T22:44:36.979Z]                                              ^~~~~~~~~~~~~~
[task 2024-10-15T22:44:36.979Z]                                              QString 
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/localsocketcontroller.cpp:362:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-10-15T22:44:36.979Z]     QTimer* t = new QTimer(this);
[task 2024-10-15T22:44:36.979Z]     ^~~~~~
[task 2024-10-15T22:44:36.979Z]     auto
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/localsocketcontroller.cpp:441:3: warning: do not declare C-style arrays, use std::array<> instead [modernize-avoid-c-arrays]
[task 2024-10-15T22:44:36.979Z]   char killpath[] = "/bin/kill";
[task 2024-10-15T22:44:36.979Z]   ^
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/localsocketcontroller.cpp:442:3: warning: do not declare C-style arrays, use std::array<> instead [modernize-avoid-c-arrays]
[task 2024-10-15T22:44:36.979Z]   char killsignal[] = "-SEGV";
[task 2024-10-15T22:44:36.979Z]   ^
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/localsocketcontroller.cpp:443:3: warning: do not declare C-style arrays, use std::array<> instead [modernize-avoid-c-arrays]
[task 2024-10-15T22:44:36.979Z]   char* const killargs[] = {killsignal, pidString.data(), nullptr};
[task 2024-10-15T22:44:36.979Z]   ^
[task 2024-10-15T22:44:36.979Z] 7781 warnings generated.
[task 2024-10-15T22:44:36.979Z] Suppressed 7774 warnings (7774 in non-user code).
[task 2024-10-15T22:44:36.979Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmptxmoxp5q.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/serverlatency.cpp
[task 2024-10-15T22:44:36.979Z] 8295 warnings generated.
[task 2024-10-15T22:44:36.979Z] Suppressed 8295 warnings (8295 in non-user code).
[task 2024-10-15T22:44:36.979Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmp48sl03dh.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/servercountrymodel.cpp
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/servercountrymodel.cpp:155:12: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.979Z]     return QVariant();
[task 2024-10-15T22:44:36.979Z]            ^~~~~~~~~~
[task 2024-10-15T22:44:36.979Z]            {}
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/servercountrymodel.cpp:160:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.979Z]       return QVariant(m_countries.at(index.row()).name());
[task 2024-10-15T22:44:36.979Z]              ^
[task 2024-10-15T22:44:36.979Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/servercountrymodel.cpp:164:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.980Z]       return QVariant(country.localizedName());
[task 2024-10-15T22:44:36.980Z]              ^
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/servercountrymodel.cpp:168:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.980Z]       return QVariant(m_countries.at(index.row()).code());
[task 2024-10-15T22:44:36.980Z]              ^
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/servercountrymodel.cpp:181:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.980Z]       return QVariant(list);
[task 2024-10-15T22:44:36.980Z]              ^
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/servercountrymodel.cpp:185:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.980Z]       return QVariant();
[task 2024-10-15T22:44:36.980Z]              ^~~~~~~~~~
[task 2024-10-15T22:44:36.980Z]              {}
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/servercountrymodel.cpp:194:12: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.980Z]     return QStringList();
[task 2024-10-15T22:44:36.980Z]            ^~~~~~~~~~~~~
[task 2024-10-15T22:44:36.980Z]            {}
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/servercountrymodel.cpp:274:13: warning: prefer a lambda to std::bind [modernize-avoid-bind]
[task 2024-10-15T22:44:36.980Z]             std::bind(sortCountryCallback, std::placeholders::_1,
[task 2024-10-15T22:44:36.980Z]             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-10-15T22:44:36.980Z]             [capture0 = &collator](auto && PH1, auto && PH2) { return sortCountryCallback(std::forward<decltype(PH1)>(PH1), std::forward<decltype(PH2)>(PH2), capture0); }
[task 2024-10-15T22:44:36.980Z] 10848 warnings generated.
[task 2024-10-15T22:44:36.980Z] Suppressed 10840 warnings (10840 in non-user code).
[task 2024-10-15T22:44:36.980Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmptmitboc2.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/captiveportal/captiveportalrequesttask.cpp
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/captiveportal/captiveportalrequesttask.cpp:42:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-10-15T22:44:36.980Z]   CaptivePortalRequest* request = new CaptivePortalRequest(this);
[task 2024-10-15T22:44:36.980Z]   ^~~~~~~~~~~~~~~~~~~~
[task 2024-10-15T22:44:36.980Z]   auto
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/fetches/qt_dist/include/QtCore/qtimer.h:77:5: warning: Potential memory leak [clang-analyzer-cplusplus.NewDeleteLeaks]
[task 2024-10-15T22:44:36.980Z]     }
[task 2024-10-15T22:44:36.980Z]     ^
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/captiveportal/captiveportalrequesttask.cpp:33:3: note: Calling 'QTimer::singleShot'
[task 2024-10-15T22:44:36.980Z]   QTimer::singleShot(30 * 1000, this, [this]() {
[task 2024-10-15T22:44:36.980Z]   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/fetches/qt_dist/include/QtCore/qtimer.h:63:9: note: Calling 'QTimer::singleShot'
[task 2024-10-15T22:44:36.980Z]         singleShot(interval, defaultTypeFor(interval), receiver, std::forward<Functor>(slot));
[task 2024-10-15T22:44:36.980Z]         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/fetches/qt_dist/include/QtCore/qtimer.h:76:24: note: Calling 'makeCallableObject<void (*)(), (lambda at /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/captiveportal/captiveportalrequesttask.cpp:33:39)>'
[task 2024-10-15T22:44:36.980Z]                        QtPrivate::makeCallableObject<Prototype>(std::forward<Functor>(slot)));
[task 2024-10-15T22:44:36.980Z]                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-10-15T22:44:36.980Z] 8508 warnings generated.
[task 2024-10-15T22:44:36.980Z] Suppressed 8507 warnings (8506 in non-user code, 1 NOLINT).
[task 2024-10-15T22:44:36.980Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmpc49jebg2.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/recentconnections.cpp
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/recentconnections.cpp:168:12: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.980Z]     return QVariant();
[task 2024-10-15T22:44:36.980Z]            ^~~~~~~~~~
[task 2024-10-15T22:44:36.980Z]            {}
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/recentconnections.cpp:173:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.980Z]       return QVariant(m_list.at(id).m_exitCountryCode);
[task 2024-10-15T22:44:36.980Z]              ^
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/recentconnections.cpp:176:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.980Z]       return QVariant(m_list.at(id).m_exitCityName);
[task 2024-10-15T22:44:36.980Z]              ^
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/recentconnections.cpp:180:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.980Z]       return QVariant(
[task 2024-10-15T22:44:36.980Z]              ^
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/recentconnections.cpp:186:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.980Z]       return QVariant(!rc.m_entryCountryCode.isEmpty() &&
[task 2024-10-15T22:44:36.980Z]              ^~~~~~~~~
[task 2024-10-15T22:44:36.980Z]              {
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/recentconnections.cpp:191:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.980Z]       return QVariant(m_list.at(id).m_entryCountryCode);
[task 2024-10-15T22:44:36.980Z]              ^
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/recentconnections.cpp:194:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.980Z]       return QVariant(m_list.at(id).m_entryCityName);
[task 2024-10-15T22:44:36.980Z]              ^
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/recentconnections.cpp:198:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.980Z]       return QVariant(
[task 2024-10-15T22:44:36.980Z]              ^
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/models/recentconnections.cpp:203:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.980Z]       return QVariant();
[task 2024-10-15T22:44:36.980Z]              ^~~~~~~~~~
[task 2024-10-15T22:44:36.980Z]              {}
[task 2024-10-15T22:44:36.980Z] 10075 warnings generated.
[task 2024-10-15T22:44:36.980Z] Suppressed 10066 warnings (10066 in non-user code).
[task 2024-10-15T22:44:36.980Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmpvaoitg9l.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/telemetry.cpp
[task 2024-10-15T22:44:36.980Z] 11728 warnings generated.
[task 2024-10-15T22:44:36.980Z] Suppressed 11728 warnings (11728 in non-user code).
[task 2024-10-15T22:44:36.980Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmpq9cxw30u.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/controller.cpp
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/controller.cpp:132:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-10-15T22:44:36.980Z]   return QString();
[task 2024-10-15T22:44:36.980Z]          ^~~~~~~~~
[task 2024-10-15T22:44:36.980Z]          {}
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/controller.cpp:1021:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-10-15T22:44:36.980Z]     TaskFunction* task = new TaskFunction([]() {});
[task 2024-10-15T22:44:36.980Z]     ^~~~~~~~~~~~
[task 2024-10-15T22:44:36.980Z]     auto
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/controller.cpp:1022:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-10-15T22:44:36.980Z]     NetworkRequest* request = new NetworkRequest(task, 200);
[task 2024-10-15T22:44:36.980Z]     ^~~~~~~~~~~~~~
[task 2024-10-15T22:44:36.980Z]     auto
[task 2024-10-15T22:44:36.980Z] 12284 warnings generated.
[task 2024-10-15T22:44:36.980Z] Suppressed 12281 warnings (12281 in non-user code).
[task 2024-10-15T22:44:36.980Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/fetches/bin/clang-tidy -export-fixes /tmp/tmprky9jfih/tmp3akx1lyo.yaml -p=/opt/worker/tasks/task_171210470794485/build /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/tasks/ipfinder/taskipfinder.cpp
[task 2024-10-15T22:44:36.980Z] /opt/worker/tasks/task_171210470794485/checkouts/vcs/src/tasks/ipfinder/taskipfinder.cpp:104:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-10-15T22:44:36.980Z]   NetworkRequest* request = new NetworkRequest(this, 200);
[task 2024-10-15T22:44:36.980Z]   ^~~~~~~~~~~~~~
[task 2024-10-15T22:44:36.980Z]   auto
[task 2024-10-15T22:44:36.980Z] 9040 warnings generated.
[task 2024-10-15T22:44:36.980Z] Suppressed 9039 warnings (9039 in non-user code).
[task 2024-10-15T22:44:36.980Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-10-15T22:44:36.980Z] Writing fixes to /opt/worker/tasks/task_171210470794485/build/clang-tidy/mozillavpn-sources-report.yaml ...
[task 2024-10-15T22:44:36.980Z] + rm -rf /opt/worker/tasks/task_171210470794485/build
[fetches 2024-10-15T22:44:39.248Z] removing /opt/worker/tasks/task_171210470794485/fetches
[fetches 2024-10-15T22:44:51.065Z] finished
[taskcluster 2024-10-15T22:44:51.078Z]    Exit Code: 0
[taskcluster 2024-10-15T22:44:51.078Z]    User Time: 1h6m4.890115s
[taskcluster 2024-10-15T22:44:51.078Z]  Kernel Time: 3m45.525008s
[taskcluster 2024-10-15T22:44:51.078Z]    Wall Time: 9m52.843255s
[taskcluster 2024-10-15T22:44:51.078Z]       Result: SUCCEEDED
[taskcluster 2024-10-15T22:44:51.079Z] === Task Finished ===
[taskcluster 2024-10-15T22:44:51.079Z] Task Duration: 9m52.849513s
[taskcluster 2024-10-15T22:44:51.238Z] Uploading artifact public/logs/certified.log from file /opt/worker/tasks/task_171210470794485/generic-worker/certified.log with content encoding "gzip", mime type "text/plain; charset=utf-8" and expiry 2025-10-15T22:34:52.570Z
[taskcluster 2024-10-15T22:44:51.595Z] Uploading artifact public/chain-of-trust.json from file /opt/worker/tasks/task_171210470794485/generic-worker/chain-of-trust.json with content encoding "gzip", mime type "text/plain; charset=utf-8" and expiry 2025-10-15T22:34:52.570Z
[taskcluster 2024-10-15T22:44:51.875Z] Uploading artifact public/chain-of-trust.json.sig from file /opt/worker/tasks/task_171210470794485/generic-worker/chain-of-trust.json.sig with content encoding "gzip", mime type "application/octet-stream" and expiry 2025-10-15T22:34:52.570Z
[taskcluster 2024-10-15T22:44:52.172Z] Uploading link artifact public/logs/live.log to artifact public/logs/live_backing.log with expiry 2025-10-15T22:34:52.570Z