-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Returning to a Custom Tab doesn't always show the same session/styling #614
Comments
Weird. When I tested this to debug something else I ended up in the app and the custom tab was just closed (which is okay since we do not restore them).
Does that mean you are in the browser and not in the custom tab anymore? 🤔 |
I saw this as well and probably failed to explain this properly in the opening issue: We're loading some information from the toolbar from the selectedSession, but if you look at logcat, you see see the CT session loading. |
I still see this reasonably often. I leave a custom tab open and do something else more memory-intensive and when I return, I see a blank screen since we don't persist the custom tab session. |
Our CustomTabActivity also has no protection against intents that have no id or re-creation without an intent. I wonder if that could happen here for a long lived background activity. |
The same seems to happen in Fenix and may be the source of some "Display already acquired" bugs if we end up with two browsers showing the selected session. |
Nominating this for AC triage. This is something we should investigate. :) @jonalmeida Have you ever tried whether "don't keep activities" or disabling "background processes" makes this easily reproducible? |
Yeah, disabling background processes was my original STR, but now we're seeing this in the wild so it might be a more important issue now. I'll try and look into this next week! :) |
@jonalmeida This is a similar issue on Fenix mozilla-mobile/fenix#2383 (comment) it may give some hints |
Thanks! It looks like the same case there. We need to figure out a restore (or graceful degradation) solution for this now. |
Nice |
I saw this happen organically by leaving a CT open for a long lived session and then returning later. Can be repro'd with the steps below.
Steps to reproduce
Expected behavior
Actual behavior
Device information
It looks like the engine or view is not being recreated for some reason.
The text was updated successfully, but these errors were encountered: