Custom tab becomes to normal brower after switching to OFF an Android permission

[Amejia481]

Video demo 🎮

Steps to reproduce

1. Set RB as default browser.
2. Open a site using custom tabs.
3. (Do not close the custom tab). Go to the RB Android settings.
4. Switch an active permission to off.
5. Go to the custom tab.

Expected behavior

The app close the custom tab.

Actual behavior

The custom tab becomes a normal browser app.

Device information

• Android device: Pixel 3

[Amejia481]

This issue occurs because the way that we are handling the custom tab session id. When we receive a request for a custom tab we are creating a new session but we are not storing it on disk, it just on memory. Then when we switch an Android permission from ON to OFF the app gets restarted and we loose the custom tab session object, the issue happens when we try to use the custom tab session id on the new sessionManager that doesn't contain it and we fold-back to the current session.

[jonalmeida]

I realized this might be a dupe of #614.