Add FxA WebChannel Extension support #858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amejia481
reviewed
Aug 2, 2019
| @@ -19,6 +19,7 @@ plugins { | |||
| allprojects { | |||
| repositories { | |||
| google() | |||
| mavenLocal() | |||
Amejia481
reviewed
Aug 2, 2019
| @@ -16,7 +16,7 @@ private object Versions { | |||
|
|
|||
| const val android_gradle_plugin = "3.4.1" | |||
|
|
|||
| const val mozilla_android_components = "+" // Always use the latest snapshot | |||
| const val mozilla_android_components = "7.0.0-vlad4" // Always use the latest snapshot | |||
There was a problem hiding this comment.
nit: I think this was an internal version
|
yea, for WIP
…On Fri, Aug 2, 2019, 10:33 Arturo Mejia ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In buildSrc/src/main/java/Dependencies.kt
<#858 (comment)>
:
> @@ -16,7 +16,7 @@ private object Versions {
const val android_gradle_plugin = "3.4.1"
- const val mozilla_android_components = "+" // Always use the latest snapshot
+ const val mozilla_android_components = "7.0.0-vlad4" // Always use the latest snapshot
nit: I think this was an internal version
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#858?email_source=notifications&email_token=AAA7N443XEZ7IASXCIGP7XLQCRASRA5CNFSM4IIVRXEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCANSL5Q#pullrequestreview-270214646>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA7N4ZPGKD635RHEIBR6HTQCRASRANCNFSM4IIVRXEA>
.
|
Amejia481
suggested changes
Aug 2, 2019
|
Sorry I didn't know 😄 ! |
|
Underlying implementation changed quite a bit, with some breaking API changes sprinkled in. See mozilla-mobile/android-components#4221. I'll re-push a PR built on top of new work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @grigoryk
Ref: mozilla-mobile/android-components#3881