This repository has been archived by the owner on Oct 7, 2022. It is now read-only.
Make Firebase project configurable, and straighten out extension message-passing #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the dev target configures for firebase
…ate to study enrollment
…to live resources
…zed message types
Carla-Moz
approved these changes
Sep 13, 2021
Thanks! I made one tiny change - now that mozilla-rally/rally-sdk#14 has landed, I'm pointing the test extension in |
rhelmer
added a commit
that referenced
this pull request
Sep 14, 2021
…age-passing (#122) * spell out how to set up and use multiple Firebase environments * remove screenshots dirs * ignore screenshots except for README * ignore local firebase cache * rename web config and put it in ./config subdir * firebase should be dev dependency, not peer * rename config to something more specific * must use import type if importsNotUsedAsValues is set to error in tsconfig * load firebase config at runtime * copy firebase web config based on current in-use firebase project name * move firebase to gitignore * configure CircleCI to override firebase per-project setting * upgrade to latest firebase-functions package * configure functions host in firebase web config file * info log on every account creation * get project name from environment for load:data target, and make sure the dev target configures for firebase * put rally site const with others * add proper build support for test extension, make sure to copy content script in * add package command to generate test extensions * wait for rally-sdk to send request before generating and sending back token * only send web-check after logging in, and handle missing attached update to study enrollment * build test extension instead of having to chck in assets * capture failure from firebase use * use demo-rally for emulator, so firebase does not attempt to connect to live resources * use demo- prefix for dev and integration test mode, per https://firebase.google.com/docs/emulator-suite/connect_firestore#choose_a_firebase_project * bump pinned sdk version * explain how to build without being logged in * prefix message types with rally-sdk, and warn not throw for unrecognized message types * keep the chrome extension version test working even though it's temporarily disabled * typo * upgrade test extension to latest rally-sdk * bump rally SDK version * point to latest official Rally SDK
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was testing out deploying to staging, I decided to document and provide a tooling support to build and deploy to different Firebase environments. It's based around
firebase use, which seems like the recommended way to support multiple Firebase sites.I straightened up a few other things while I was in there:
Note that you don't need to use
firebase useor any of the deployment stuff if you don't want to,npm run devstill runs the local emulators. I changed the default project to start with "demo-" because Firebase considers that a local-only project and will not attempt to connect to any live resources.