-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
The current failure in CI is:
On the surface, the problem here seems to be that the es version of the That's worth looking into, but @Carla-Moz note that I seem to be able to make the error go away if I revert the changes in Do you want to give that a try and see if it unblocks you? We should also go through and make sure we're on the latest version of our |
@rhelmer, Thank you! Yes, that removed the error for me. And yes, let's make sure our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big improvement overall :) I made a few suggestions that you can take or leave, the only one I feel strongly about is I found by pasting in passwords, or using Firefox's auto-suggest password feature:
Note how the buttons are disabled even though a valid password, if I paste in the password it with the keyboard it works fine. I suspect it's because the button state is changed in handleKeyup
and that event doesn't fire in this case. If I right-click and paste with the mouse I see the same behavior, buttons stay disabled.
Related to button state, I noticed the buttons are not disabled even though I'm getting the "password too short" warning:
…latform into add-client-side-validation
* added basic validation * returned form ids to original names * reverted to old package-lock.json * updated form * addressed changes * addressed failed tests
closes #99