Verify email dialog #167
Verify email dialog #167
Conversation
…y/rally-web-platform into verify-email-dialog
…y/rally-web-platform into verify-email-dialog
|
should the build directory be included? |
Nope! I'll update. |
There was a problem hiding this comment.
@Carla-Moz I'm going to take a look at the actual substance here next :) But it looks like this is wiping out everything in the docs/ dir and landing a built site in there - is that expected? Maybe we should put it in a different dir?
Also the dirs in ./screenshots shouldn't be checked in, those are just from the integration test (the only reason they go in the working directory is so we can have CI serve them up), I think those probably shouldn't be landed.
The actual changes here lgtm so far, as I mentioned I'm going to pull this down and test it next.
Oh yikes, I didn't intend for this to happen regarding the docs directory. My original intent was to update .gitignore for the docs-build dir but it looks I ended up changing more than I planned. Will revert to previous commit for .gitingore and fix. Thanks for catching this! |
package.json
Outdated
| @@ -24,7 +24,8 @@ | |||
| "test:integration:jest": "jest ./tests/integration/", | |||
| "test:integration": "npm run build:web:emulator && npm run build:functions && ./scripts/integration-test.sh", | |||
| "storybook": "start-storybook -s ./static -p 6006", | |||
| "build-storybook": "build-storybook" | |||
| "build-storybook": "build-storybook -o storybook/build -s ./static", | |||
| "build-static-webapp": "expo build:web" | |||
There was a problem hiding this comment.
Should expo (and expo-cli) be dev dependencies?
I apologize for how large this one is and promise the next ones will be a lot smaller. I had to go from dialogs to cards, along with a bunch of cleanup. This merge is finalizing all the storybook sign-in flows before I create a separate branch to update our current sign-in experience, which will pop up around Monday.