Sign in flow #169
Sign in flow #169
Conversation
There was a problem hiding this comment.
The code lgtm, I left a few comments wondering if we can remove commented-out code vs. leaving it, but if you have plans for it it's fine.
Two things I noticed while testing:
- the font on the sidebar looks different, is this intentional?
8:24:03 AM [vite] Error when evaluating SSR module /Users/mozilla/src/rally-web-platform/src/routes/__layout.svelte:
TypeError: Line must be greater than or equal to 1, got -1
at BasicSourceMapConsumer.SourceMapConsumer_findMapping [as _findMapping] (/Users/mozilla/src/rally-web-platform/node_modules/vite/dist/node/chunks/dep-85dbaaa7.js:65402:13)
at BasicSourceMapConsumer.SourceMapConsumer_originalPositionFor [as originalPositionFor] (/Users/mozilla/src/rally-web-platform/node_modules/vite/dist/node/chunks/dep-85dbaaa7.js:65471:22)
at /Users/mozilla/src/rally-web-platform/node_modules/vite/dist/node/chunks/dep-85dbaaa7.js:66410:34
at String.replace (<anonymous>)
at /Users/mozilla/src/rally-web-platform/node_modules/vite/dist/node/chunks/dep-85dbaaa7.js:66400:21
at Array.map (<anonymous>)
at ssrRewriteStacktrace (/Users/mozilla/src/rally-web-platform/node_modules/vite/dist/node/chunks/dep-85dbaaa7.js:66399:10)
at instantiateModule (/Users/mozilla/src/rally-web-platform/node_modules/vite/dist/node/chunks/dep-85dbaaa7.js:66544:28)
From a quick search it looks like it's something specific to vite's SSR in dev mode, maybe introduced in a recent update? It doesn't seem to be causing test failures and nothing I can find wrong while testing, but it'd be good to understand why it's happening.
| btnID = {welcomeCard ? "signin" : "create"} | ||
| on:click={() => { | ||
| welcomeCard ? handleTrigger("signin") : handleTrigger("create"); | ||
| console.log("THIS IS A HIT ON LAUNCH CARD") |
There was a problem hiding this comment.
Is this just for debugging?
There was a problem hiding this comment.
Yes! I realized after that I forgot to delete it.
For reference, on staging it looks like:
|
This is weird re the sidebar styles cause I don't see it on my local. I'll do another review of the CSS again. Most likely forgot to update some styles or something. Ah, just a browser issue. Firefox v Chrome. Always gotta remember to look at both, :P. As for the vite error, I'll investigate as well. Don't want it to potentially break something down the line. |
This PR includes three changes:
closes #158