-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make the emergency shutoff button unclickeable when disabled #3028
Merged
gabrielBusta
merged 9 commits into
mozilla-releng:main
from
MelakuAlehegn:emergency-shutoff-button
Oct 25, 2023
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8cb1337
make the emergency shutoff button unclickeable when disabled
MelakuAlehegn 6ee3a48
remove unused code
MelakuAlehegn cbd1977
eslint error fixes
MelakuAlehegn b00e5a3
fix for eslint errors
MelakuAlehegn c54c94f
fix for firefoxci-taskcluster / test-backend
MelakuAlehegn 4c869e2
restoring unrelated files changed
MelakuAlehegn b076972
eslint fix
MelakuAlehegn 0d3356b
change file permissions
MelakuAlehegn f1c577e
more files pesmission change
MelakuAlehegn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes are hitting some script files not related with the issue. Seems like file metadata was changed or something like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@allan-silva, I have only changed ui/src/views/Rules/ListRules/index.jsx file, but somehow this files have been added too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I create another PR with a different branch name for this issue?, seems like this could be resolved if I only stages the index.js file to git so that the files wouldn't get pushed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that's the easiest way for you to get a clean PR, please go ahead. It is also possible to revert the changes from your current branch.