Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the emergency shutoff button unclickeable when disabled #3028

Merged
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file modified agent/run.sh
100755 → 100644
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes are hitting some script files not related with the issue. Seems like file metadata was changed or something like this.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allan-silva, I have only changed ui/src/views/Rules/ListRules/index.jsx file, but somehow this files have been added too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I create another PR with a different branch name for this issue?, seems like this could be resolved if I only stages the index.js file to git so that the files wouldn't get pushed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the easiest way for you to get a clean PR, please go ahead. It is also possible to revert the changes from your current branch.

Empty file.
Empty file modified agent/scripts/test-entrypoint.sh
100755 → 100644
Empty file.
Empty file modified client/setup.py
100755 → 100644
Empty file.
Empty file modified maintenance/pin-helper.sh
100755 → 100644
Empty file.
Empty file modified maintenance/pin.sh
100755 → 100644
Empty file.
Empty file modified scripts/adhoc-tests.py
100755 → 100644
Empty file.
Empty file modified scripts/initdb_and_run.sh
100755 → 100644
Empty file.
Empty file modified scripts/manage-db.py
100755 → 100644
Empty file.
Empty file modified scripts/reset-stage-db.sh
100755 → 100644
Empty file.
Empty file modified scripts/run-batch-deletes.sh
100755 → 100644
Empty file.
Empty file modified scripts/run.sh
100755 → 100644
Empty file.
Empty file modified scripts/test-rules.py
100755 → 100644
Empty file.
Empty file modified src/auslib/blobs/apprelease.py
100755 → 100644
Empty file.
Empty file modified src/auslib/blobs/base.py
100755 → 100644
Empty file.
Empty file modified taskcluster/docker/skopeo/push_image.sh
100755 → 100644
Empty file.
Empty file modified tests/blobs/test_apprelease.py
100755 → 100644
Empty file.
Empty file modified ui/scripts/deploy
100755 → 100644
Empty file.
10 changes: 9 additions & 1 deletion ui/src/views/Rules/ListRules/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -1368,7 +1368,15 @@ function ListRules(props) {
icon={<PauseIcon />}
tooltipOpen
tooltipTitle="Disable Updates"
onClick={handleDisableUpdates}
onClick={
!isLoading &&
!!username &&
!filteredProductChannelIsShutoff &&
!!productChannelQueries &&
!!productChannelQueries[1]
? handleDisableUpdates
: undefined
}
/>
</SpeedDial>
</Dashboard>
Expand Down