Fix redis healthcheck

mozilla-services · Jan 16, 2025 · f82bc8a · f82bc8a
1 parent 73ef3c7
commit f82bc8a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 16 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/autopush-common/Cargo.toml b/autopush-common/Cargo.toml
@@ -59,7 +59,7 @@ grpcio = { version = "=0.13.0", features = ["openssl"], optional = true }
 grpcio-sys = { version = "=0.13.0", optional = true }
 protobuf = { version = "=2.28.0", optional = true } # grpcio does not support protobuf 3+
 form_urlencoded = { version = "1.2", optional = true }
-redis = { version = "0.27.6", features = ["aio", "tokio-comp"]}
+redis = { version = "0.28.1", features = ["aio", "tokio-comp"]}
 
 [dev-dependencies]
 mockito = "0.31"

diff --git a/autopush-common/src/db/redis/redis_client/mod.rs b/autopush-common/src/db/redis/redis_client/mod.rs
@@ -503,7 +503,8 @@ impl DbClient for RedisClientImpl {
     }
 
     async fn health_check(&self) -> DbResult<bool> {
-        let _ = self.connection().await?;
+        let mut con = self.connection().await?;
+        let _: () = con.ping().await?;
         Ok(true)
     }