bug: Remove discussion comment and useless bool return

Closes #1026
mozilla-services · Sep 26, 2017 · 44cdc30 · 44cdc30
1 parent 2e07a7d
commit 44cdc30
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/autopush/db.py b/autopush/db.py
@@ -436,7 +436,7 @@ def save_channels(self, uaid, channels):
 
     @track_provisioned
     def store_message(self, notification):
-        # type: (WebPushNotification) -> bool
+        # type: (WebPushNotification)
         """Stores a WebPushNotification in the message table"""
         item = dict(
             uaid=hasher(notification.uaid.hex),
@@ -448,7 +448,6 @@ def store_message(self, notification):
             updateid=notification.update_id
         )
         self.table.put_item(data=item, overwrite=True)
-        return True
 
     @track_provisioned
     def delete_message(self, notification):

diff --git a/autopush/router/webpush.py b/autopush/router/webpush.py
@@ -109,7 +109,7 @@ def route_notification(self, notification, uaid_data):
                                   response_body="Retry Request",
                                   errno=201)
 
-        # - Lookup client
+        # - Lookup client again to get latest node state after save.
         #   - Success (node found): Notify node of new notification
         #     - Success: Done, return 200
         #     - Error (no client): Done, return 202
@@ -119,7 +119,6 @@ def route_notification(self, notification, uaid_data):
         #   - Error (db error): Done, return 202
         #   - Error (no client) : Done, return 404
         try:
-            # is this call redundant? We already get uaid_data passed in
             uaid_data = yield deferToThread(router.get_uaid, uaid)
         except JSONResponseError:
             returnValue(self.stored_response(notification))