Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

catch int(jwt['exp']) raising TypeErrors #1326

Closed
pjenvey opened this issue Apr 5, 2019 · 0 comments · Fixed by #1332
Closed

catch int(jwt['exp']) raising TypeErrors #1326

pjenvey opened this issue Apr 5, 2019 · 0 comments · Fixed by #1332
Assignees
@pjenvey
Labels
bug p1

Comments

@pjenvey
Copy link
Member

pjenvey commented Apr 5, 2019

Seen on sentry:

https://sentry.prod.mozaws.net/operations/autopush-prod/issues/5490142/

Any type could be embedded in the jwt JSON, e.g. a list. We already catch ValueErrors from int() but it could additionally raise a TypeError on incorrect types
@pjenvey pjenvey self-assigned this Apr 26, 2019
pjenvey added a commit that referenced this issue Apr 26, 2019
@pjenvey
fix: handle TypeErrors too
72566f4 
Closes #1326
pjenvey added a commit that referenced this issue Apr 26, 2019
@pjenvey
fix: handle TypeErrors too
79420a9 
Closes #1326
@pjenvey pjenvey mentioned this issue Apr 26, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjenvey pjenvey

Labels
bug p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle TypeErrors too mozilla-services/autopush
2 participants
@pjenvey @jrconlin