Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Refactor registration and message endpoints #491

Closed
bbangert opened this issue Jun 28, 2016 · 0 comments
Closed

Refactor registration and message endpoints #491

bbangert opened this issue Jun 28, 2016 · 0 comments
Assignees
@jrconlin
Labels
p1
Milestone
PUSHSVC-0: quality

Comments

@bbangert
Copy link
Contributor

bbangert commented Jun 28, 2016 •
edited
Loading

In #379, the simplepush and webpush handlers were refactored and relocated to web/ locations. The registration and message handlers in endpoint.py should also be relocated and updated to use the validation schemas.
@bbangert bbangert mentioned this issue Jun 28, 2016
Closed
3 tasks
@bbangert bbangert added this to the PUSHSVC-0: quality milestone Jun 28, 2016
@bbangert bbangert added the ready label Jun 28, 2016
@bbangert bbangert added the p2 label Aug 19, 2016
@bbangert bbangert added p1 and removed p2 labels Aug 31, 2016
@jrconlin jrconlin self-assigned this Sep 29, 2016
@bbangert bbangert removed the ready label Sep 29, 2016
jrconlin added a commit that referenced this issue Oct 3, 2016
@jrconlin
feat: move Message and Registration handlers to own validated class
b91d5fd 
Continuing the effort to break up endpoint.py, move Message and
Registration handlers to their own marshmallow validated classes. I have
tried not to disturb tests unless absolutely required (e.g. @patch for
some reason stopped modifying `uuid.uuid4()`)

closes #491
@jrconlin jrconlin mentioned this issue Oct 3, 2016
Merged
jrconlin added a commit that referenced this issue Oct 3, 2016
@jrconlin
feat: move Message and Registration handlers to own validated class
d657a84 
Continuing the effort to break up endpoint.py, move Message and
Registration handlers to their own marshmallow validated classes. I have
tried not to disturb tests unless absolutely required (e.g. @patch for
some reason stopped modifying `uuid.uuid4()`)

closes #491
jrconlin added a commit that referenced this issue Oct 5, 2016
@jrconlin
feat: move Message and Registration handlers to own validated class
a1dad6c 
Continuing the effort to break up endpoint.py, move Message and
Registration handlers to their own marshmallow validated classes. I have
tried not to disturb tests unless absolutely required (e.g. @patch for
some reason stopped modifying `uuid.uuid4()`)

closes #491
jrconlin added a commit that referenced this issue Oct 5, 2016
@jrconlin
feat: move Message and Registration handlers to own validated class
cb69f5b 
Continuing the effort to break up endpoint.py, move Message and
Registration handlers to their own marshmallow validated classes. I have
tried not to disturb tests unless absolutely required (e.g. @patch for
some reason stopped modifying `uuid.uuid4()`)

closes #491
jrconlin added a commit that referenced this issue Oct 5, 2016
@jrconlin
feat: move Message and Registration handlers to own validated class
346f2f3 
Continuing the effort to break up endpoint.py, move Message and
Registration handlers to their own marshmallow validated classes. I have
tried not to disturb tests unless absolutely required (e.g. @patch for
some reason stopped modifying `uuid.uuid4()`)

closes #491
jrconlin added a commit that referenced this issue Oct 6, 2016
@jrconlin
feat: move Message and Registration handlers to own validated class
2e689f3 
Continuing the effort to break up endpoint.py, move Message and
Registration handlers to their own marshmallow validated classes. I have
tried not to disturb tests unless absolutely required (e.g. @patch for
some reason stopped modifying `uuid.uuid4()`)

closes #491
jrconlin added a commit that referenced this issue Oct 6, 2016
@jrconlin
feat: move Message and Registration handlers to own validated class
322e798 
Continuing the effort to break up endpoint.py, move Message and
Registration handlers to their own marshmallow validated classes. I have
tried not to disturb tests unless absolutely required (e.g. @patch for
some reason stopped modifying `uuid.uuid4()`)

closes #491
jrconlin added a commit that referenced this issue Oct 6, 2016
@jrconlin
feat: move Message and Registration handlers to own validated class
a6a6868 
Continuing the effort to break up endpoint.py, move Message and
Registration handlers to their own marshmallow validated classes. I have
tried not to disturb tests unless absolutely required (e.g. @patch for
some reason stopped modifying `uuid.uuid4()`)

closes #491
jrconlin added a commit that referenced this issue Oct 6, 2016
@jrconlin
feat: move Message and Registration handlers to own validated class
096b55f 
Continuing the effort to break up endpoint.py, move Message and
Registration handlers to their own marshmallow validated classes. I have
tried not to disturb tests unless absolutely required (e.g. @patch for
some reason stopped modifying `uuid.uuid4()`)

closes #491
jrconlin added a commit that referenced this issue Oct 6, 2016
@jrconlin
feat: move Message and Registration handlers to own validated class
c4af39a 
Continuing the effort to break up endpoint.py, move Message and
Registration handlers to their own marshmallow validated classes. I have
tried not to disturb tests unless absolutely required (e.g. @patch for
some reason stopped modifying `uuid.uuid4()`)

closes #491
jrconlin added a commit that referenced this issue Oct 6, 2016
@jrconlin
feat: move Message and Registration handlers to own validated class
ea3b48c 
Continuing the effort to break up endpoint.py, move Message and
Registration handlers to their own marshmallow validated classes. I have
tried not to disturb tests unless absolutely required (e.g. @patch for
some reason stopped modifying `uuid.uuid4()`)

closes #491
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrconlin jrconlin

Labels
p1
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

No branches or pull requests
2 participants
@jrconlin @bbangert