Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Trap JWT/JWS error exceptions #610

Closed
jrconlin opened this issue Aug 19, 2016 · 3 comments
Closed

Trap JWT/JWS error exceptions #610

jrconlin opened this issue Aug 19, 2016 · 3 comments
Assignees
@jrconlin
Labels
bug p1
Milestone
PUSHSVC-0: quality

Comments

@jrconlin
Copy link
Member

jrconlin commented Aug 19, 2016 •
edited by bbangert
Loading

https://sentry.prod.mozaws.net/operations/autopush-prod/issues/345791/

Some non-critical JWT errors are leaking into Sentry. We should trap those and just reject the submission with appropriate error codes and info.
@jrconlin jrconlin self-assigned this Aug 19, 2016
@bbangert bbangert added this to the PUSHSVC-0: quality milestone Aug 19, 2016
@bbangert bbangert added the p1 label Aug 19, 2016
@ghost
Copy link

ghost commented Aug 19, 2016

Gotta catch 'em all... https://github.com/mpdavis/python-jose/blob/master/jose/exceptions.py

@bbangert
Copy link
Contributor

The two parent exceptions there, yup!

@jrconlin
Copy link
Member Author

Looks like just one: JOSEError, All others are classed off that one.
#smallMiracles

jrconlin added a commit that referenced this issue Aug 19, 2016
@jrconlin
bug: trap JWS/JWT errors from being reported as Sentry Errors
3e0dd71 
Silence Jose errors from handling the Auth header.

Closes #610
@jrconlin jrconlin mentioned this issue Aug 19, 2016
Merged
@jrconlin jrconlin removed the ready label Aug 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrconlin jrconlin

Labels
bug p1
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

No branches or pull requests
3 participants
@pjenvey @jrconlin @bbangert