Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Don't attempt to JSON serialize Items #631

Closed
bbangert opened this issue Aug 25, 2016 · 0 comments · Fixed by #635
Closed

Don't attempt to JSON serialize Items #631

bbangert opened this issue Aug 25, 2016 · 0 comments · Fixed by #635
Assignees
@jrconlin
Labels
bug p1
Milestone
PUSHSVC-0: quality

Comments

@bbangert
Copy link
Member

Per Sentry: https://sentry.prod.mozaws.net/operations/autopush-prod/issues/346327/

Traceback:

TypeError: <boto.dynamodb2.items.Item object at 0x7fecededb550> is not JSON serializable
  File "/usr/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1128, in _inlineCallbacks
    result = g.send(result)
  File "/app/autopush/router/webpush.py", line 68, in preflight_check
    record=json.dumps(uaid_data))
  File "/usr/local/lib/python2.7/json/__init__.py", line 244, in dumps
    return _default_encoder.encode(obj)
  File "/usr/local/lib/python2.7/json/encoder.py", line 207, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/usr/local/lib/python2.7/json/encoder.py", line 270, in iterencode
    return _iterencode(o, 0)
  File "/usr/local/lib/python2.7/json/encoder.py", line 184, in default
    raise TypeError(repr(o) + " is not JSON serializable")
@bbangert bbangert added this to the PUSHSVC-0: quality milestone Aug 25, 2016
@jrconlin jrconlin self-assigned this Aug 26, 2016
jrconlin added a commit that referenced this issue Aug 26, 2016
@jrconlin
bug: do not try to JSON serialize log output
90bb768 
Some info that needs to be logged is not JSON serializable. Use repr()
for now.

closes #631
@jrconlin jrconlin mentioned this issue Aug 26, 2016
Merged
@jrconlin jrconlin removed the ready label Aug 26, 2016
jrconlin added a commit that referenced this issue Aug 26, 2016
@jrconlin
bug: do not try to JSON serialize log output
9861edb 
Some info that needs to be logged is not JSON serializable. Use repr()
for now.

closes #631
jrconlin added a commit that referenced this issue Aug 29, 2016
@jrconlin
bug: do not try to JSON serialize log output
34d0aae 
Some info that needs to be logged is not JSON serializable. Use repr()
for now.

closes #631
jrconlin added a commit that referenced this issue Aug 30, 2016
@jrconlin
bug: do not try to JSON serialize log output
f131d19 
Some info that needs to be logged is not JSON serializable. Use repr()
for now.

closes #631
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrconlin jrconlin

Labels
bug p1
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

Successfully merging a pull request may close this issue.

bug: do not try to JSON serialize log output mozilla-services/autopush
2 participants
@jrconlin @bbangert