Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

bogus deferToThread call in simplepush router #877

Closed
pjenvey opened this issue Apr 20, 2017 · 2 comments
Closed

bogus deferToThread call in simplepush router #877

pjenvey opened this issue Apr 20, 2017 · 2 comments
Assignees
@pjenvey
Labels
bug p1
Milestone
PUSHSVC-0: quality

Comments

@pjenvey
Copy link
Member

pjenvey commented Apr 20, 2017

Noticed this a while back in some rarely called code:

https://github.com/mozilla-services/autopush/blob/55e91c5/autopush/router/simple.py#L164

(requests.post is actually being called there vs deferring the call)
@pjenvey pjenvey added this to the PUSHSVC-0: quality milestone Apr 20, 2017
@pjenvey pjenvey self-assigned this Apr 20, 2017
@pjenvey pjenvey added the ready label Apr 26, 2017
@pjenvey pjenvey added p1 and removed p3 labels Aug 2, 2017
@pjenvey pjenvey closed this as completed Aug 2, 2017
@pjenvey pjenvey removed the ready label Aug 2, 2017
@pjenvey
Copy link
Member Author

pjenvey commented Aug 2, 2017

OBE gone w/ simplepush

@pjenvey
Copy link
Member Author

pjenvey commented Aug 2, 2017

actually we've moved this into webpush, so still an issue

@pjenvey pjenvey reopened this Aug 2, 2017
pjenvey added a commit that referenced this issue Aug 2, 2017
@pjenvey
fix: actually defer this requests.post call
3cc6754 
Closes #877
@pjenvey pjenvey mentioned this issue Aug 2, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjenvey pjenvey

Labels
bug p1
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

No branches or pull requests
2 participants
@pjenvey @jrconlin