Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Log simplepush message_id as a string #925

Closed
bbangert opened this issue Jun 19, 2017 · 0 comments
Closed

Log simplepush message_id as a string #925

bbangert opened this issue Jun 19, 2017 · 0 comments
Assignees
@bbangert
Labels
bug Operational p1
Milestone
2017Q2-2.1 Report...

Comments

@bbangert
Copy link
Member

Simplepush uses numbers for the version to send, which results in the message_id being logged as an int. They're supposed to be strings though, and the inconsistency means our logging gets messed up. They should be logged as strings as they are for webpush messages.
@bbangert bbangert self-assigned this Jun 19, 2017
bbangert added a commit that referenced this issue Jun 19, 2017
@bbangert
fix: ensure simplepush messages log message_id as str
a312e50 
For logging consistency on the backend we should use the same type
for logging values for the same key. Simplepush was logging its
version as an int however.

Closes #925
@bbangert bbangert mentioned this issue Jun 19, 2017
Merged
bbangert added a commit that referenced this issue Jun 19, 2017
@bbangert
fix: ensure simplepush messages log message_id as str
dabfb6d 
For logging consistency on the backend we should use the same type
for logging values for the same key. Simplepush was logging its
version as an int however.

Closes #925
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbangert bbangert

Labels
bug Operational p1
Projects
None yet
Milestone
2017Q2-2.1 Report generated twice a m...
Development

No branches or pull requests
1 participant
@bbangert