This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
chore: update all libs to latest versions and fix jws conflict #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest crypto library update introduced a change that this fixes as well. Closes #453
| # on the JWT object. Vapid is a bit more creative in how it | ||
| # stores data into a JWT and breaks expectations. We would have to | ||
| # turn off most of the validation in order for it to be useful. | ||
| return json.loads(jws.verify(token, vk, algorithms=["ES256"])) |
There was a problem hiding this comment.
part of me wonders if/when this comes back to bite us, but looking at the jose code, they'd have to change a bunch of stuff to get the old behavior back.
|
r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest crypto library update introduced a change that this fixes as
well.
Closes #453
@jrconlin r?