Skip to content
This repository has been archived by the owner on Aug 13, 2019. It is now read-only.

Use ciso8601 to parse CSV dates, fixes #443 #444

Merged
merged 3 commits into from
May 3, 2018
Merged

Use ciso8601 to parse CSV dates, fixes #443 #444

merged 3 commits into from
May 3, 2018

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented May 2, 2018

No description provided.

@peterbe peterbe requested a review from leplatrem May 2, 2018 16:52
@peterbe
Copy link
Contributor Author

peterbe commented May 2, 2018

In my virtualenv:

Python 3.6.5 (default, Mar 30 2018, 06:41:53)
[GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import ciso8601
>>> ciso8601.parse_datetime('2017-06-11T12:20:10.2Z')
datetime.datetime(2017, 6, 11, 12, 20, 10, 200000, tzinfo=<UTC>)

On the Docker instance in CI:

Python 3.6.5 (default, Mar 31 2018, 01:18:39)
[GCC 4.9.2] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import ciso8601
>>> ciso8601.parse_datetime('2017-06-11T12:20:10.2Z')
datetime.datetime(2017, 6, 11, 12, 20, 10, 200000)

Awesome. I guess I need to read the docs a bit better or write a wrapper function that makes this more predictably across different environments.

@peterbe
Copy link
Contributor Author

peterbe commented May 2, 2018

The reason is because I had pytz installed in my virtualenv. It's not in requirements.txt so I must have installed it from some other dev tool.

See closeio/ciso8601#19

@peterbe peterbe merged commit 785c8bd into mozilla-services:master May 3, 2018
@peterbe peterbe deleted the use-ciso8601-to-parse-csv-dates-fixes-443 branch May 3, 2018 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant